Merge lp:~elopio/snappy/translator-comment into lp:~snappy-dev/snappy/snappy-moved-to-github

Proposed by Leo Arias on 2015-07-02
Status: Merged
Approved by: Leo Arias on 2015-07-02
Approved revision: 550
Merged at revision: 549
Proposed branch: lp:~elopio/snappy/translator-comment
Merge into: lp:~snappy-dev/snappy/snappy-moved-to-github
Diff against target: 156 lines (+14/-28)
6 files modified
cmd/snappy/cmd_hwassign.go (+2/-2)
cmd/snappy/cmd_hwunassign.go (+1/-1)
cmd/snappy/cmd_list.go (+2/-2)
cmd/snappy/cmd_rollback.go (+1/-1)
po/snappy.pot (+7/-21)
update-pot (+1/-1)
To merge this branch: bzr merge lp:~elopio/snappy/translator-comment
Reviewer Review Type Date Requested Status
Michael Terry (community) 2015-07-02 Approve on 2015-07-02
Review via email: mp+263673@code.launchpad.net

Commit Message

Generate only the translators comments that start with TRANSLATORS:
Fixed the translator comment for hw-unassign.

To post a comment you must log in.
Michael Terry (mterry) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmd/snappy/cmd_hwassign.go'
2--- cmd/snappy/cmd_hwassign.go 2015-07-01 14:56:49 +0000
3+++ cmd/snappy/cmd_hwassign.go 2015-07-02 17:16:22 +0000
4@@ -55,7 +55,7 @@
5 func (x *cmdHWAssign) doHWAssign() error {
6 if err := snappy.AddHWAccess(x.Positional.PackageName, x.Positional.DevicePath); err != nil {
7 if err == snappy.ErrHWAccessAlreadyAdded {
8- // the first %s is a pkgname, the second %s is a path
9+ // TRANSLATORS: the first %s is a pkgname, the second %s is a path
10 fmt.Printf(i18n.G("'%s' previously allowed access to '%s'. Skipping\n"), x.Positional.PackageName, x.Positional.DevicePath)
11 return nil
12 }
13@@ -63,7 +63,7 @@
14 return err
15 }
16
17- // the first %s is a pkgname, the second %s is a path
18+ // TRANSLATORS: the first %s is a pkgname, the second %s is a path
19 fmt.Printf(i18n.G("'%s' is now allowed to access '%s'\n"), x.Positional.PackageName, x.Positional.DevicePath)
20 return nil
21 }
22
23=== modified file 'cmd/snappy/cmd_hwunassign.go'
24--- cmd/snappy/cmd_hwunassign.go 2015-07-01 14:56:49 +0000
25+++ cmd/snappy/cmd_hwunassign.go 2015-07-02 17:16:22 +0000
26@@ -57,7 +57,7 @@
27 return err
28 }
29
30- // TRANSLATORS: the %s is a pkgname
31+ // TRANSLATORS: the first %s is a pkgname, the second %s is a path
32 fmt.Printf(i18n.G("'%s' is no longer allowed to access '%s'\n"), x.Positional.PackageName, x.Positional.DevicePath)
33 return nil
34 }
35
36=== modified file 'cmd/snappy/cmd_list.go'
37--- cmd/snappy/cmd_list.go 2015-07-01 14:56:49 +0000
38+++ cmd/snappy/cmd_list.go 2015-07-02 17:16:22 +0000
39@@ -156,10 +156,10 @@
40
41 if needsReboot {
42 if snappy.VersionCompare(otherVersion, currentVersion) > 0 {
43- // the %s is a pkgname
44+ // TRANSLATORS: the %s is a pkgname
45 fmt.Fprintln(o, fmt.Sprintf(i18n.G("Reboot to use the new %s."), otherName))
46 } else {
47- // the first %s is a pkgname the second a version
48+ // TRANSLATORS: the first %s is a pkgname the second a version
49 fmt.Fprintln(o, fmt.Sprintf(i18n.G("Reboot to use %s version %s."), otherName, otherVersion))
50 }
51 }
52
53=== modified file 'cmd/snappy/cmd_rollback.go'
54--- cmd/snappy/cmd_rollback.go 2015-07-01 14:56:49 +0000
55+++ cmd/snappy/cmd_rollback.go 2015-07-02 17:16:22 +0000
56@@ -65,7 +65,7 @@
57 if err != nil {
58 return err
59 }
60- // the first %s is a pkgname, the second %s is the new version
61+ // TRANSLATORS: the first %s is a pkgname, the second %s is the new version
62 fmt.Printf(i18n.G("Setting %s to version %s\n"), pkg, nowVersion)
63
64 m := snappy.NewMetaRepository()
65
66=== modified file 'po/snappy.pot'
67--- po/snappy.pot 2015-07-01 14:56:49 +0000
68+++ po/snappy.pot 2015-07-02 17:16:22 +0000
69@@ -7,7 +7,7 @@
70 msgid ""
71 msgstr "Project-Id-Version: snappy\n"
72 "Report-Msgid-Bugs-To: snappy-devel@lists.ubuntu.com\n"
73- "POT-Creation-Date: 2015-07-01 16:56+0200\n"
74+ "POT-Creation-Date: 2015-07-02 11:15-0600\n"
75 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
76 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
77 "Language-Team: LANGUAGE <LL@li.org>\n"
78@@ -26,17 +26,17 @@
79 msgid "%s: %s\n"
80 msgstr ""
81
82-#. TRANSLATORS: the %s is a pkgname
83+#. TRANSLATORS: the first %s is a pkgname, the second %s is a path
84 #, c-format
85 msgid "'%s' is no longer allowed to access '%s'\n"
86 msgstr ""
87
88-#. the first %s is a pkgname, the second %s is a path
89+#. TRANSLATORS: the first %s is a pkgname, the second %s is a path
90 #, c-format
91 msgid "'%s' is now allowed to access '%s'\n"
92 msgstr ""
93
94-#. the first %s is a pkgname, the second %s is a path
95+#. TRANSLATORS: the first %s is a pkgname, the second %s is a path
96 #, c-format
97 msgid "'%s' previously allowed access to '%s'. Skipping\n"
98 msgstr ""
99@@ -86,20 +86,6 @@
100 msgid "First boot has already run"
101 msgstr ""
102
103-#.
104-#. Disabling review tools run until the output reflects reality more closely
105-#.
106-#. _, err = exec.LookPath(clickReview)
107-#. if err != nil {
108-#. fmt.Fprintf(os.Stderr, "Warning: could not review package (%s not available)\n", clickReview)
109-#. }
110-#.
111-#. cmd := exec.Command(clickReview, snapPackage)
112-#. cmd.Stdout = os.Stdout
113-#. cmd.Stderr = os.Stderr
114-#. // we ignore the error for now
115-#. _ = cmd.Run()
116-#.
117 #. TRANSLATORS: the %s is a pkgname
118 #, c-format
119 msgid "Generated '%s' snap\n"
120@@ -150,12 +136,12 @@
121 msgid "Query the store for available packages"
122 msgstr ""
123
124-#. the first %s is a pkgname the second a version
125+#. TRANSLATORS: the first %s is a pkgname the second a version
126 #, c-format
127 msgid "Reboot to use %s version %s."
128 msgstr ""
129
130-#. the %s is a pkgname
131+#. TRANSLATORS: the %s is a pkgname
132 #, c-format
133 msgid "Reboot to use the new %s."
134 msgstr ""
135@@ -189,7 +175,7 @@
136 msgid "Set properties of system or package"
137 msgstr ""
138
139-#. the first %s is a pkgname, the second %s is the new version
140+#. TRANSLATORS: the first %s is a pkgname, the second %s is the new version
141 #, c-format
142 msgid "Setting %s to version %s\n"
143 msgstr ""
144
145=== modified file 'update-pot'
146--- update-pot 2015-07-01 07:48:19 +0000
147+++ update-pot 2015-07-02 17:16:22 +0000
148@@ -11,7 +11,7 @@
149 fi
150
151 xgettext -d snappy -o "$OUTPUT" --c++ --from-code=UTF-8 \
152- --indent --add-comments --no-location --sort-output \
153+ --indent --add-comments=TRANSLATORS: --no-location --sort-output \
154 --package-name=snappy \
155 --msgid-bugs-address=snappy-devel@lists.ubuntu.com \
156 --keyword=NG:1,2 --keyword=G \

Subscribers

People subscribed via source and target branches