Merge lp:~elopio/snappy/test_go_version into lp:~snappy-dev/snappy/snappy-moved-to-github
Proposed by
Leo Arias
Status: | Merged |
---|---|
Approved by: | Leo Arias |
Approved revision: | 587 |
Merged at revision: | 588 |
Proposed branch: | lp:~elopio/snappy/test_go_version |
Merge into: | lp:~snappy-dev/snappy/snappy-moved-to-github |
Diff against target: |
78 lines (+35/-12) 2 files modified
_integration-tests/tests/02_test_versions (+0/-7) _integration-tests/tests/latest/list_test.go (+35/-5) |
To merge this branch: | bzr merge lp:~elopio/snappy/test_go_version |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Federico Gimenez (community) | Approve | ||
Review via email: mp+265076@code.launchpad.net |
Commit message
Translated the version integration test to go.
Description of the change
This one is a little tricky. We can't pass the version from the host to the testbed, because we accept relative versions like -1 or nothing to mean latest. So we would have to query the system-image server for the latest image, and calculate the relative version. But then we would need to know the device, which can be a lot of things and we don't take as an argument. Much too work for not much value IMO, so I settled for checking the value from the config.
To post a comment you must log in.
Looks good, +1
Maybe a system-image client as you mention can become useful, we can get all the required data from snappy info, then it's just a matter of parsing a remote json.