Merge lp:~elopio/snappy/test_go_search into lp:~snappy-dev/snappy/snappy-moved-to-github

[Leo Arias]

Translated the search integration test to go.

[Federico Gimenez (fgimenez)]

Looks good, IMO it would be nice to be able to test different scenarios here (perhaps in other tests too) through table driven tests [1], what do you think?

Thanks!

[1] https://code.google.com/p/go-wiki/wiki/TableDrivenTests

[Leo Arias (elopio)]

I'm torn about this. I mean, of course tests with scenarios are cool, and I want them. But I'm not sure how many scenarios we should cover in the integration suite. Maybe we should search for an app and a framework, I don't know searching for more stuff would be of value.

[Federico Gimenez (fgimenez)]

We can go ahead with this and discuss how and when to use the table driven tests, maybe for the basic happy/unhappy installation cases, snap and framework, etc.

Thanks!

review: Approve

=== removed file '_integration-tests/tests/06_test_search_framework'
--- _integration-tests/tests/06_test_search_framework	2015-06-15 15:36:29 +0000
+++ _integration-tests/tests/06_test_search_framework	1970-01-01 00:00:00 +0000
@@ -1,4 +0,0 @@
-test() {
-       T="$framework[[:space:]]+[0-9.]+[[:space:]]+.*"
-       test_regexp "$T" $SNAPPY search "$framework" 
-}

=== added file '_integration-tests/tests/latest/search_test.go'
--- _integration-tests/tests/latest/search_test.go	1970-01-01 00:00:00 +0000
+++ _integration-tests/tests/latest/search_test.go	2015-07-15 05:55:07 +0000
@@ -0,0 +1,44 @@
+// -*- Mode: Go; indent-tabs-mode: t -*-
+
+/*
+ * Copyright (C) 2015 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+package latest
+
+import (
+	. "../common"
+
+	. "gopkg.in/check.v1"
+)
+
+var _ = Suite(&searchSuite{})
+
+type searchSuite struct {
+	SnappySuite
+}
+
+func (s *searchSuite) TestSearchFrameworkMustPrintMatch(c *C) {
+	searchOutput := ExecCommand(c, "snappy", "search", "hello-dbus-fwk")
+
+	expected := "(?ms)" +
+		"Name +Version +Summary *\n" +
+		".*" +
+		"^hello-dbus-fwk +.* +hello-dbus-fwk *\n" +
+		".*"
+
+	c.Assert(searchOutput, Matches, expected)
+}