Code review comment for lp:~elopio/snappy/new_kernel_file_name

Federico Gimenez (fgimenez) wrote :

Thanks for this, Leo, hopefully we'll get this make this work soon with the new kernel files layout.

I'm getting an error in an installApp test not related to these changes, probably we haven't merged the branch that fixes this yet, let me know if it's an issue for you too:

/home/fgimenez/workspace/snappy/new_kernel_file_name/_integration-tests/tests/installApp_test.go:122:
    ...open /home/fgimenez/workspace/snappy/new_kernel_file_name/_integration-tests/tests/installApp_test.go: no such file or directory
... obtained string = "" +
... "Installing unexisting.canonical\n" +
... "unexisting failed to install: snappy package not found\n"
... expected string = "" +
... "Installing unexisting.canonical\n" +
... "unexisting.canonical failed to install: snappy package not found\n"

After fixing it I get this one that may be actually related to the changes:

****** Resuming failoverSuite.TestZeroSizeInitrd after reboot
PASS: <autogenerated>:15: failoverSuite.SetUpTest 0.000s

snappy list
Name Date Version Developer
ubuntu-core 2015-09-22 180 ubuntu
generic-amd64 2015-09-22 1.4 canonical
/home/fgimenez/workspace/snappy/new_kernel_file_name/_integration-tests/tests/failover_zero_size_file_test.go:197:
    ...open /home/fgimenez/workspace/snappy/new_kernel_file_name/_integration-tests/tests/failover_zero_size_file_test.go: no such file or directory
/home/fgimenez/workspace/snappy/new_kernel_file_name/_integration-tests/tests/failover_zero_size_file_test.go:142:
    ...open /home/fgimenez/workspace/snappy/new_kernel_file_name/_integration-tests/tests/failover_zero_size_file_test.go: no such file or directory
... obtained int = 0
... expected int = 1
... 0 files matching /boot/grub/a/snappy-selftest-initrd*, 1 expected

It seems that after the failover it boots correctly but when tries to revert the changes it tries to do find the modified files in the a partition. If things went good during the setup of the failure this should be the b partition, can you please confirm?

« Back to merge proposal