Merge lp:~elopio/snappy/fix1496515-go_vet_missing_return into lp:~snappy-dev/snappy/15.04-deprecated

Proposed by Leo Arias
Status: Rejected
Rejected by: John Lenton
Proposed branch: lp:~elopio/snappy/fix1496515-go_vet_missing_return
Merge into: lp:~snappy-dev/snappy/15.04-deprecated
Diff against target: 12 lines (+1/-1)
1 file modified
helpers/helpers.go (+1/-1)
To merge this branch: bzr merge lp:~elopio/snappy/fix1496515-go_vet_missing_return
Reviewer Review Type Date Requested Status
John Lenton (community) Disapprove
Review via email: mp+271352@code.launchpad.net

This proposal supersedes a proposal from 2015-09-16.

Commit message

Fixed the vet check: added the missing return of the error in rsync helper.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) wrote :

15.04-deprecated is deprecated \o/

review: Disapprove

Unmerged revisions

480. By Leo Arias

Fixed the vet check: added the missing return of the error in rsync helper.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'helpers/helpers.go'
2--- helpers/helpers.go 2015-06-04 15:00:44 +0000
3+++ helpers/helpers.go 2015-09-16 17:51:20 +0000
4@@ -396,7 +396,7 @@
5 // XXX: on snappy-trunk we can use CopyFile here
6 output, err := exec.Command("cp", "-va", src, dst).CombinedOutput()
7 if err != nil {
8- fmt.Errorf("Failed to copy %s to %s (%s)", src, dst, output)
9+ return fmt.Errorf("Failed to copy %s to %s (%s)", src, dst, output)
10 }
11 }
12 return nil

Subscribers

People subscribed via source and target branches

to all changes: