Snappy

Merge lp:~elopio/snappy/fix1496486-go_vet_unreachable into lp:~snappy-dev/snappy/snappy-moved-to-github

  1. fix1496486-go_vet_unreachable
  2. Merge into snappy-moved-to-github
Proposed by Leo Arias
Status: Rejected
Rejected by: Leo Arias
Proposed branch: lp:~elopio/snappy/fix1496486-go_vet_unreachable
Merge into: lp:~snappy-dev/snappy/snappy-moved-to-github
Diff against target: 12 lines (+0/-2)
1 file modified
i18n/xgettext-go/main.go (+0/-2)
To merge this branch: bzr merge lp:~elopio/snappy/fix1496486-go_vet_unreachable
Reviewer Review Type Date Requested Status
Leo Arias (community) Disapprove
Review via email: mp+271343@code.launchpad.net

Commit message

Fixed go vet on i18n/xgettext-go/main.go: removed unreachable statement.

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

Fix already proposed at https://code.launchpad.net/~chipaca/snappy/precommit/+merge/271290

review: Disapprove

Unmerged revisions

706. By Leo Arias

Fixed go vet on i18n/xgettext-go/main.go: removed unreachable statement.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'i18n/xgettext-go/main.go'
2--- i18n/xgettext-go/main.go 2015-09-10 06:16:31 +0000
3+++ i18n/xgettext-go/main.go 2015-09-16 16:36:28 +0000
4@@ -89,8 +89,6 @@
5 default:
6 panic(fmt.Sprintf("unknown type: %v", val))
7 }
8-
9- return ""
10 }
11
12 func inspectNodeForTranslations(fset *token.FileSet, f *ast.File, n ast.Node) bool {

Subscribers

People subscribed via source and target branches