Merge lp:~elopio/snappy/backport-gocheck into lp:~snappy-dev/snappy/15.04-deprecated
Proposed by
Leo Arias
on 2015-08-02
| Status: | Merged |
|---|---|
| Approved by: | Leo Arias on 2015-08-03 |
| Approved revision: | 466 |
| Merged at revision: | 465 |
| Proposed branch: | lp:~elopio/snappy/backport-gocheck |
| Merge into: | lp:~snappy-dev/snappy/15.04-deprecated |
| Diff against target: |
671 lines (+69/-67) 44 files modified
clickdeb/deb_test.go (+2/-2) cmd/snappy/cmd_low_level_unpack_test.go (+1/-1) cmd/snappy/cmd_set_test.go (+2/-2) coreconfig/config_test.go (+2/-2) debian/control (+1/-1) dependencies.tsv (+1/-1) helpers/cmp_test.go (+1/-1) helpers/helpers_test.go (+1/-1) helpers/touch_test.go (+1/-1) logger/logger_test.go (+1/-1) oauth/oauth_test.go (+1/-1) partition/bootloader_grub_test.go (+1/-1) partition/bootloader_uboot_test.go (+1/-1) partition/partition_test.go (+2/-2) partition/utils_test.go (+1/-1) policy/policy_test.go (+3/-2) priv/priv_test.go (+1/-1) progress/progress_test.go (+2/-2) release/release_test.go (+2/-2) snappy/auth_test.go (+13/-13) snappy/build_test.go (+1/-1) snappy/click_test.go (+2/-2) snappy/common_test.go (+3/-2) snappy/config_test.go (+1/-1) snappy/datadir_test.go (+1/-1) snappy/dbus_test.go (+1/-1) snappy/firstboot_test.go (+1/-1) snappy/hashes_test.go (+1/-1) snappy/hwaccess_test.go (+1/-1) snappy/install_test.go (+1/-1) snappy/oem_test.go (+1/-1) snappy/parts_test.go (+1/-1) snappy/purge_test.go (+1/-1) snappy/remove_test.go (+1/-1) snappy/rollback_test.go (+1/-1) snappy/security_test.go (+1/-1) snappy/set_test.go (+1/-1) snappy/snapp_test.go (+1/-1) snappy/sort_test.go (+1/-1) snappy/systemimage_native_test.go (+1/-1) snappy/systemimage_test.go (+2/-2) snappy/timeout_test.go (+1/-1) snappy/udev_test.go (+1/-1) systemd/systemd_test.go (+2/-2) |
| To merge this branch: | bzr merge lp:~elopio/snappy/backport-gocheck |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sergio Schvezov | Approve on 2015-08-03 | ||
| Federico Gimenez (community) | 2015-08-02 | Approve on 2015-08-03 | |
|
Review via email:
|
|||
Commit Message
Backported the change to use gopkg.in/check.v1.
Description of the Change
We need a more recent version of gocheck in order to backport the integration tests. They use some features that are not in launchpad, like TestName()
To post a comment you must log in.
| Sergio Schvezov (sergiusens) wrote : | # |
This should be a problem as it doesn't affect the (delivered part of the) product itself but the testing side and this should indeed just work.
I do see some carry over gofmt things, but meh :-)
review:
Approve
| Leo Arias (elopio) wrote : | # |
meh it is. Thanks to you both.


LGTM, thanks