Merge lp:~elopio/selenium-simple-test/workaround-alert-dict into lp:selenium-simple-test

[Leo Arias]

the text of the alert is sometimes returned in a dictionary. This workaround takes the item from the dictionary when this happens.

Because of a selenium issue [1], the text of the alert is sometimes returned in a dictionary.
This workaround takes the item from the dictionary when this happens.

[1] http://code.google.com/p/selenium/issues/detail?id=2955

[Corey Goldberg (coreygoldberg)]

looks good to me. thanks.

review: Approve

=== modified file 'src/sst/actions.py'
--- src/sst/actions.py	2011-11-28 17:51:15 +0000
+++ src/sst/actions.py	2011-11-28 21:16:36 +0000
@@ -979,6 +979,10 @@
     waitfor(browser.switch_to_alert)
     alert = browser.switch_to_alert()
     alert_text = alert.text
+    # XXX workaround because Selenium sometimes returns the value in a
+    # dictionary. See http://code.google.com/p/selenium/issues/detail?id=2955
+    if isinstance(alert_text, dict):
+        alert_text = alert_text['text']
     if expected_text and expected_text != alert_text:
         error_message = 'Element text should be %r.\nIt is %r.' \
             % (expected_text, alert_text)