Merge lp:~elopio/payclient/creditcardrequest_equality into lp:payclient

[Leo Arias]

Implement the equality functions for the CreditClassRequest object.

In order to test the arguments passed to the API client from the helper utilities, we need to compare the actual CreditCardRequest with the expected one. This branch makes that easier.

The branch that will use this feature is:
https://code.launchpad.net/~elopio/u1-test-utils/pay_client_return_response/+merge/155609

[lp:~elopio/payclient/creditcardrequest_equality]

5. By Leo Arias on 2013-03-26

Added the not equal test.

6. By Leo Arias on 2013-03-27

Added a README file.

7. By Leo Arias on 2013-03-27

Added the missing tests suggested by matias.

[Matias Bordese (matiasb)]

LGTM

review: Approve

[Leo Arias (elopio)]

<matiasb> elopio: on the first one, I would add another test for eq, with some data (besides the empty case); and you should add a test comparing 2 different kind of requests (PaymentRequest vs CardRequest), since that's also required by your eq check

=== added file 'README'
--- README	1970-01-01 00:00:00 +0000
+++ README	2013-03-27 17:36:19 +0000
@@ -0,0 +1,14 @@
+Getting started:
+================
+
+1. Get the code:
+
+    bzr branch lp:payclient
+
+2. Install the requirements:
+
+    sudo apt-get install python-dateutil python-mock
+
+3. Run the tests:
+
+    ./tarmat_tests.sh

=== modified file 'src/payclient/client.py'
--- src/payclient/client.py	2013-03-25 19:52:22 +0000
+++ src/payclient/client.py	2013-03-27 17:36:19 +0000
@@ -44,6 +44,13 @@
     )
     make_unattended_default = False
 
+    def __eq__(self, other):
+        return (isinstance(other, self.__class__)
+            and self.__dict__ == other.__dict__)
+
+    def __ne__(self, other):
+        return not self.__eq__(other)
+
 
 class PaymentRequest(PistonSerializable):
     _atts = (

=== modified file 'src/payclient/tests/test_client.py'
--- src/payclient/tests/test_client.py	2013-03-25 20:46:05 +0000
+++ src/payclient/tests/test_client.py	2013-03-27 17:36:19 +0000
@@ -54,6 +54,40 @@
         request = CreditCardRequest()
         self.assertEqual(request.make_unattended_default, False)
 
+    def test_equals_with_no_attributes(self):
+        request1 = CreditCardRequest()
+        request2 = CreditCardRequest()
+        self.assertEqual(request1, request2)
+
+    def test_equals_with_attributes(self):
+        params = {
+            'shop_id': 'test_shop',
+            'open_id': 'test_openid',
+            'card_type': 'test_card',
+            'card_holder': 'test_name',
+            'card_number': '123',
+            'card_ccv': '321',
+            'card_expiration_month': '12',
+            'card_expiration_year': '2013',
+            'make_unattended_default': False,
+            'billing_address': {
+                'address': 'test_address'
+            },
+        }
+        request1 = CreditCardRequest(**params)
+        request2 = CreditCardRequest(**params)
+        self.assertEqual(request1, request2)
+
+    def test_not_equals_with_attributes(self):
+        request1 = CreditCardRequest(shop_id='test1')
+        request2 = CreditCardRequest(shop_id='test2')
+        self.assertNotEqual(request1, request2)
+
+    def test_not_equals_with_different_class(self):
+        request1 = CreditCardRequest()
+        request2 = PaymentRequest()
+        self.assertNotEqual(request1, request2)
+
 
 class PaymentRequestTestCase(TestCase):
     def test_request_attributes(self):