Merge lp:~elopio/gallery-app/override_toolbar into lp:gallery-app

Proposed by Leo Arias
Status: Merged
Approved by: Arthur Mello
Approved revision: 944
Merged at revision: 946
Proposed branch: lp:~elopio/gallery-app/override_toolbar
Merge into: lp:gallery-app
Diff against target: 27 lines (+10/-2)
1 file modified
tests/autopilot/gallery_app/emulators/main_screen.py (+10/-2)
To merge this branch: bzr merge lp:~elopio/gallery-app/override_toolbar
Reviewer Review Type Date Requested Status
Arthur Mello (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+213703@code.launchpad.net

Commit message

Properly override the toolkit toolbar autopilot helper.

To post a comment you must log in.
943. By Leo Arias

Updated the copyright year.

944. By Leo Arias

Fixed typo.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Arthur Mello (artmello) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/gallery_app/emulators/main_screen.py'
2--- tests/autopilot/gallery_app/emulators/main_screen.py 2013-08-09 13:55:35 +0000
3+++ tests/autopilot/gallery_app/emulators/main_screen.py 2014-04-01 19:19:03 +0000
4@@ -1,13 +1,21 @@
5 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
6-# Copyright 2013 Canonical
7+# Copyright 2013, 2014 Canonical
8 #
9 # This program is free software: you can redistribute it and/or modify it
10 # under the terms of the GNU General Public License version 3, as published
11 # by the Free Software Foundation.
12
13 from ubuntuuitoolkit import emulators as toolkit_emulators
14-from toolbar import Toolbar
15+from gallery_app.emulators import toolbar
16
17
18 class MainScreen(toolkit_emulators.MainView):
19 """An emulator class that makes it easy to interact with the gallery app"""
20+
21+ def get_toolbar(self):
22+ """Return the Toolbar emulator of the MainView.
23+
24+ Overriden because the gallery app has custom buttons.
25+
26+ """
27+ return self.select_single(toolbar.Toolbar)

Subscribers

People subscribed via source and target branches

to all changes: