Merge lp:~elopio/canonical-identity-provider/tox_and_py2+3 into lp:~canonical-isd-hackers/canonical-identity-provider/ssoclient

[Leo Arias]

Made the code compatible with py2.7 and py3.3. All tests in tox passing for both environments.
Added tox to test in both environments.

[Natalia Bidart (nataliabidart)]

Looks good!

review: Approve

=== modified file 'Makefile'
--- Makefile	2013-09-13 15:24:49 +0000
+++ Makefile	2013-12-02 15:17:20 +0000
@@ -1,19 +1,14 @@
-ENV_PATH=.env
-PIP=pip
-PYTHON=python
-VIRTUALENV=virtualenv
+TOX_PATH=.tox
 
 .PHONY: clean env test
 
 all: clean env test
 
 env:
-	$(VIRTUALENV) $(ENV_PATH)
+	tox --notest
 
 clean:
-	rm -rf $(ENV_PATH)
-	rm -rf mock-*.egg oauthlib-*.egg requests-*.egg requests_oauthlib-*.egg
-	rm -rf ssoclient.egg-info
+	rm -rf $(TOX_PATH)
 
-test: env
-	. $(ENV_PATH)/bin/activate && $(PYTHON) setup.py test
+test: 
+	tox

=== modified file 'ssoclient/__init__.py'
--- ssoclient/__init__.py	2013-09-13 15:13:08 +0000
+++ ssoclient/__init__.py	2013-12-02 15:17:20 +0000
@@ -1,4 +1,4 @@
 # Copyright 2013 Canonical Ltd. This software is licensed under
 # the GNU Affero General Public License version 3 (see the file
 # LICENSE).
-__version__ = '2.0'
+__version__ = '2.1'

=== modified file 'ssoclient/tests/__init__.py'
--- ssoclient/tests/__init__.py	2013-09-13 15:13:08 +0000
+++ ssoclient/tests/__init__.py	2013-12-02 15:17:20 +0000
@@ -1,4 +1,3 @@
 # Copyright 2013 Canonical Ltd. This software is licensed under
 # the GNU Affero General Public License version 3 (see the file
 # LICENSE).
-

=== modified file 'ssoclient/tests/test_v2.py'
--- ssoclient/tests/test_v2.py	2013-11-07 18:27:41 +0000
+++ ssoclient/tests/test_v2.py	2013-12-02 15:17:20 +0000
@@ -3,12 +3,21 @@
 # Copyright 2013 Canonical Ltd. This software is licensed under
 # the GNU Affero General Public License version 3 (see the file
 # LICENSE).
+
+from __future__ import unicode_literals
+
+try:
+    str = unicode
+except NameError:
+    pass  # Forward compatibility with Py3k
+
 import json
 import unittest
 
 from datetime import datetime
 
 from mock import (
+    ANY,
     MagicMock,
     patch,
 )
@@ -92,7 +101,7 @@
     response = Response()
     response.status_code = status_code
     if content is not None and json_dump:
-        content = json.dumps(content)
+        content = str(json.dumps(content)).encode('utf-8')
     response._content = content
     return response
 
@@ -105,7 +114,7 @@
         return response
 
     def test_error_code_raises_correct_exception(self):
-        for code, exc in ERRORS.iteritems():
+        for code, exc in ERRORS.items():
             response = mock_response(exc.status_code, dict(code=code))
             with self.assertRaises(exc):
                 self.do_test(response)
@@ -241,7 +250,7 @@
             credentials['consumer_key'], credentials['consumer_secret'],
             credentials['token_key'], credentials['token_secret'],
         )
-        self.assertTrue(all(isinstance(val, unicode) for
+        self.assertTrue(all(isinstance(val, str) for
                             val in self.mock_oauth.call_args[0]))
 
 
@@ -388,8 +397,14 @@
         self.mock_request.assert_called_once_with(
             'POST', 'http://foo.com/tokens/password',
             headers={'Content-Type': 'application/json'},
-            data='{"token": null, "email": "%s"}' % self.email,
+            data=ANY
         )
+        # Load the data string into a dictionary so the order of the keys
+        # doesn't matter.
+        _, kwargs = self.mock_request.call_args
+        self.assertEqual(
+            {'token': None, 'email': self.email},
+            json.loads(kwargs.get('data')))
 
     def test_request_password_reset_without_email(self):
         self.mock_request.return_value = mock_response(
@@ -411,11 +426,17 @@
             self.email, 'token1234')
 
         self.assertEqual(response, content)
-        self.assertEqual(self.mock_request.call_args, [
-            ('POST', 'http://foo.com/tokens/password'),
-            {'headers': {'Content-Type': 'application/json'},
-             'data': '{"token": "token1234", "email": "%s"}' % self.email},
-        ])
+        self.mock_request.assert_called_once_with(
+            'POST', 'http://foo.com/tokens/password',
+            headers={'Content-Type': 'application/json'},
+            data=ANY
+        )
+        # Load the data string into a dictionary so the order of the keys
+        # doesn't matter.
+        _, kwargs = self.mock_request.call_args
+        self.assertEqual(
+            {'token': 'token1234', 'email': self.email},
+            json.loads(kwargs.get('data')))
 
     def test_request_password_reset_for_suspended_account(self):
         self.mock_request.return_value = mock_response(
@@ -717,7 +738,7 @@
         self.mock_request.return_value = mock_response(
             200, dict(is_valid=True))
 
-        http_url = u'http://localhost/~/test/doc/dåc-id'
+        http_url = 'http://localhost/~/test/doc/dåc-id'
         result = self.client.validate_request(
             http_url=http_url, http_method='GET', authorization='something')
 
@@ -729,16 +750,17 @@
         self.mock_request.return_value = mock_response(
             200, dict(is_valid=True))
 
-        http_url = u'http://localhost/~/test/doc/dåc-id'.encode('utf-8')
+        http_url = 'http://localhost/~/test/doc/dåc-id'
         result = self.client.validate_request(
-            http_url=http_url, http_method='GET', authorization='something')
+            http_url=http_url.encode('utf-8'), http_method='GET',
+            authorization='something')
 
         self.assertEqual(result, {'is_valid': True})
         self.assert_validate_request_called(
             http_url=http_url, authorization='something')
 
     def test_non_ascii_url_not_utf8_encoded(self):
-        http_url = u'http://localhost/~/test/doc/dåc-id'.encode('latin-1')
+        http_url = 'http://localhost/~/test/doc/dåc-id'.encode('latin-1')
 
         with self.assertRaises(errors.ClientError) as ctx:
             self.client.validate_request(

=== modified file 'ssoclient/v2/client.py'
--- ssoclient/v2/client.py	2013-11-29 16:01:45 +0000
+++ ssoclient/v2/client.py	2013-12-02 15:17:20 +0000
@@ -1,6 +1,14 @@
 # Copyright 2013 Canonical Ltd. This software is licensed under
 # the GNU Affero General Public License version 3 (see the file
 # LICENSE).
+
+from __future__ import unicode_literals
+
+try:
+    str = unicode
+except NameError:
+    pass  # Forward compatibility with Py3k
+
 import logging
 
 from datetime import datetime
@@ -49,10 +57,10 @@
         # json library is in use.
         # oauthlib requires them to be unicode - so we coerce to be sure.
         if credentials is not None:
-            consumer_key = unicode(credentials.get('consumer_key', ''))
-            consumer_secret = unicode(credentials.get('consumer_secret', ''))
-            token_key = unicode(credentials.get('token_key', ''))
-            token_secret = unicode(credentials.get('token_secret', ''))
+            consumer_key = str(credentials.get('consumer_key', ''))
+            consumer_secret = str(credentials.get('consumer_secret', ''))
+            token_key = str(credentials.get('token_key', ''))
+            token_secret = str(credentials.get('token_secret', ''))
             oauth = OAuth1(
                 consumer_key,
                 consumer_secret,
@@ -83,7 +91,7 @@
         return result
 
     def account_details(self, openid, token=None, expand=False):
-        openid = unicode(openid)
+        openid = str(openid)
         oauth = self._unicode_credentials(token)
         url = '/accounts/%s?expand=%s' % (openid, str(expand).lower())
 
@@ -143,7 +151,7 @@
             raise errors.ClientError(msg=msg)
 
         http_url = data.get('http_url', '')
-        if not isinstance(http_url, unicode):
+        if not isinstance(http_url, str):
             try:
                 data['http_url'] = http_url.decode('utf-8')
             except UnicodeError:

=== modified file 'ssoclient/v2/errors.py'
--- ssoclient/v2/errors.py	2013-09-30 20:47:01 +0000
+++ ssoclient/v2/errors.py	2013-12-02 15:17:20 +0000
@@ -2,6 +2,8 @@
 # the GNU Affero General Public License version 3 (see the file
 # LICENSE).
 
+from __future__ import unicode_literals
+
 class UnexpectedApiError(Exception):
     """An unexpected client error."""
 
@@ -39,7 +41,7 @@
             # of a subclass - so still fetch it from the payload body
             code = body.get('code')
             msg = "%s: %s" % (response.status_code, code)
-            extra = ', '.join('%s: %r' % i for i in self.extra.iteritems())
+            extra = ', '.join('%s: %r' % i for i in self.extra.items())
             if extra:
                 msg += ' (%s)' % extra
         super(ApiException, self).__init__(msg)

=== modified file 'ssoclient/v2/http.py'
--- ssoclient/v2/http.py	2013-10-01 00:17:10 +0000
+++ ssoclient/v2/http.py	2013-12-02 15:17:20 +0000
@@ -1,6 +1,9 @@
 # Copyright 2013 Canonical Ltd. This software is licensed under
 # the GNU Affero General Public License version 3 (see the file
 # LICENSE).
+
+from __future__ import unicode_literals
+
 import functools
 import json
 

=== added file 'tox.ini'
--- tox.ini	1970-01-01 00:00:00 +0000
+++ tox.ini	2013-12-02 15:17:20 +0000
@@ -0,0 +1,9 @@
+# Copyright 2013 Canonical Ltd. This software is licensed under
+# the GNU Affero General Public License version 3 (see the file
+# LICENSE).
+
+[tox]
+envlist = py27, py33
+
+[testenv]
+commands = {envpython} setup.py test