Autopilot

Merge lp:~elopio/autopilot/fix1257055-slow_drag into lp:autopilot

fix1257055-slow_drag
Merge into trunk

Proposed by Leo Arias on 2014-01-19

Status:

Superseded

Proposed branch:

lp:~elopio/autopilot/fix1257055-slow_drag

Merge into:

lp:autopilot

Diff against target:

1650 lines (+1161/-233)

7 files modified

autopilot/input/_X11.py (+3/-3)
autopilot/input/__init__.py (+4/-4)
autopilot/input/_common.py (+12/-2)
autopilot/input/_uinput.py (+352/-216)
autopilot/tests/functional/test_input_stack.py (+6/-5)
autopilot/tests/unit/test_input.py (+782/-3)
debian/control (+2/-0)

To merge this branch:

bzr merge lp:~elopio/autopilot/fix1257055-slow_drag

High

Fix Released

Link a bug report

Reviewer	Review Type	Status
Thomi Richards (community)		Needs Fixing on 2014-02-09
PS Jenkins bot	continuous-integration	Needs Fixing on 2014-01-20
Leo Arias		Pending
Review via email: mp+202205@code.launchpad.net

This proposal supersedes a proposal from 2014-01-19.

This proposal has been superseded by a proposal from 2014-02-11.

Commit message

Added Mouse, Touch and Pointer drags with rate.

lp:~elopio/autopilot/fix1257055-slow_drag updated on 2014-01-19

421. By Leo Arias on 2014-01-19: Updated the copyright years.
422. By Leo Arias on 2014-01-19: Added the rate to the Pointer drag.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-01-19:

FAILED: Continuous integration, rev:421
http://jenkins.qa.ubuntu.com/job/autopilot-ci/406/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-trusty-amd64-ci/132/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-trusty-armhf-ci/132/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/2453/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2455/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/406/rebuild

review: Needs Fixing (continuous-integration)

lp:~elopio/autopilot/fix1257055-slow_drag updated on 2014-01-19

423. By Leo Arias on 2014-01-19: Renamed MockTouch to MockUinputTouch.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-01-19:

FAILED: Continuous integration, rev:423
http://jenkins.qa.ubuntu.com/job/autopilot-ci/407/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-trusty-amd64-ci/133/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-trusty-armhf-ci/133/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/2454/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2456/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/407/rebuild

review: Needs Fixing (continuous-integration)

lp:~elopio/autopilot/fix1257055-slow_drag updated on 2014-01-20

424. By Leo Arias on 2014-01-20: Merged with trunk.
425. By Leo Arias on 2014-01-20: Added python-evdev as a build-dep.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-01-20:

FAILED: Continuous integration, rev:425
http://jenkins.qa.ubuntu.com/job/autopilot-ci/413/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-trusty-amd64-ci/139/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-trusty-armhf-ci/139/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/2480/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2482/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/413/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Thomi Richards (thomir-deactivatedaccount) wrote on 2014-02-09:

Hi,

I'm not sure if this MP is still relevant. If it's not, please delete the proposal to merge. If it is, then:

39 - def drag(self, x1, y1, x2, y2):
40 + def drag(self, x1, y1, x2, y2, rate=10):

If you're adding (or removing, or changing) a parameter to a public method, please document it in the docstrings. What exactly is 'rate' measured in anyway?

82 - def drag(self, x1, y1, x2, y2):
83 + def drag(self, x1, y1, x2, y2, rate=10):

You introduce a new parameter, and then don't use it at all in the method.

In general this MP makes me feel rather uneasy. You're introducing a new parameter, and some code changes, and I can't see any justification for it.

If this is really needed, I think it might be worth moving the algorithm to a common location, and making both the X11 and uinput backends be able to use it. That way, you can test it without needing to mock out anything.

Anyway, please talk to me on IRC about this. We need to either clean it up and merge it, or remove it from the review queue.

review: Needs Fixing

Revision history for this message

Thomi Richards (thomir-deactivatedaccount) wrote on 2014-02-09:

Hi,

In order to make our review queue a little more sane, I'm setting this to WIP. If/when you need a new review, please set it back to 'Needs Review', and (optionally) ping someone on the AP team.

Thanks.

lp:~elopio/autopilot/fix1257055-slow_drag updated on 2014-02-11

426. By Leo Arias on 2014-02-11: Merged with prerequisite branch.
427. By Leo Arias on 2014-02-11: Fixed the imports.
428. By Leo Arias on 2014-02-11: Added comments for the rate parameter.
429. By Leo Arias on 2014-02-11: Updated the tests.
430. By Leo Arias on 2014-02-11: Removed unused import.
431. By Leo Arias on 2014-02-11: Removed extra line.
432. By Leo Arias on 2014-02-11: s/should/must
433. By Leo Arias on 2014-02-11: Added a test with time_between_events.
434. By Leo Arias on 2014-02-11: We can't use the real Mouse, so switch to touch backend for now.
435. By Leo Arias on 2014-02-11: Updated the fake.