address-book-app

Merge lp:~elopio/address-book-app/autopilot-get_header_from_toolkit into lp:~phablet-team/address-book-app/staging

  1. autopilot-get_header_from_toolkit
  2. Merge into staging
Proposed by Leo Arias
Status: Merged
Approved by: Renato Araujo Oliveira Filho
Approved revision: 207
Merged at revision: 207
Proposed branch: lp:~elopio/address-book-app/autopilot-get_header_from_toolkit
Merge into: lp:~phablet-team/address-book-app/staging
Diff against target: 12 lines (+1/-1)
1 file modified
tests/autopilot/address_book_app/pages/_common.py (+1/-1)
To merge this branch: bzr merge lp:~elopio/address-book-app/autopilot-get_header_from_toolkit
Reviewer Review Type Date Requested Status
Renato Araujo Oliveira Filho (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+225729@code.launchpad.net

Commit message

Call get_header from ubuntu-ui-toolkit-autopilot.

Description of the change

The upcoming ubuntu-ui-toolkit release has some changes on the header. To be able to work with those changes, we should call get_header from the toolkit autopilot helpers instead of selecting it with our own code.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:207
http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-ci/198/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1591
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1357
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-amd64-ci/198
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-armhf-ci/198
        deb: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-armhf-ci/198/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-i386-ci/198
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1864
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2592
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2592/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9325
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1124
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1521
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1521/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-team-address-book-app-staging-ci/198/rebuild

review: Approve (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/address_book_app/pages/_common.py'
2--- tests/autopilot/address_book_app/pages/_common.py 2014-05-22 13:42:45 +0000
3+++ tests/autopilot/address_book_app/pages/_common.py 2014-07-05 07:46:40 +0000
4@@ -28,7 +28,7 @@
5 def get_header(self):
6 """Return the Header custom proxy object of the Page."""
7 return self.get_root_instance().select_single(
8- 'Header', objectName='MainView_Header')
9+ 'MainWindow').get_header()
10
11
12 class PageWithBottomEdge(ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase):

Subscribers

People subscribed via source and target branches

to all changes: