Merge lp:~elfy/ubuntu-manual-tests/XFCEOptional into lp:ubuntu-manual-tests
Proposed by
Elfy
Status: | Merged | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 298 | ||||||||||||||||||||||||||||
Proposed branch: | lp:~elfy/ubuntu-manual-tests/XFCEOptional | ||||||||||||||||||||||||||||
Merge into: | lp:ubuntu-manual-tests | ||||||||||||||||||||||||||||
Diff against target: |
304 lines (+51/-45) 7 files modified
testcases/packages/Xfce/1561_Xfce4 Screenshooter (+5/-2) testcases/packages/Xfce/1565_Xfce4 Mouse Settings (+4/-4) testcases/packages/Xfce/1575_Xfce4 Appearance Settings (+10/-8) testcases/packages/Xfce/1576_Xfce4 Session and Startup Settings (+8/-8) testcases/packages/Xfce/1580_Xfdesktop Settings (+19/-17) testcases/packages/Xfce/1581_Xfce4 MIME Settings (+2/-2) testcases/packages/Xfce/1583_Xfce4 Task Manager (+3/-4) |
||||||||||||||||||||||||||||
To merge this branch: | bzr merge lp:~elfy/ubuntu-manual-tests/XFCEOptional | ||||||||||||||||||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Pires | Approve | ||
Review via email: mp+218310@code.launchpad.net |
Description of the change
Various changes to testcase prior to testing for 1410.
To post a comment you must log in.
1561_Xfce4 Screenshooter test:
Looks good and the proposed rewording does correct an inadequacy, so IMO it should be merged and the tracker updated.
1565_Xfce4 Mouse Settings test:
Even though the replacement of the tabs numbers by their respective names was needed, I would also change the test line 2, from <dt>Click the "Device:" menu</dt> to <dt>Click the "Device:" drop-down list</dt> to make it cleaner.
1575_Xfce4 Appearance Settings:
All the occurrences of 'main menu' are correctly replaced by 'Whiskermenu', which replaced it as of 14.04, but line 2 of the test should be removed because the launcher panel has been dropped from Trusty Tahr onward.
1576_Xfce4 Session and Startup Settings:
In order to make this test more coherent and cohesive, besides replacing all the occurrences of 'From Action buttons...' with 'From whiskermenu...' I would also replace all the existing occurrences of 'Open Settings Manager from the menu' with 'Open Settings Manager from Whiskermenu'.
1580_Xfdesktop Settings:
Besides a typo in <dt>Deslect apply to all workspaces</dt>, it looks good and it should be merged and the tracker updated.
1581_Xfce4 MIME Settings:
Looks good and it should be merged and the tracker updated.
1583_Xfce4 Task Manager:
The corrections made look good but I would also change the first line of the test from <dt>Locate "Task Manager" under "System" on the menu and click on it</dt> to <dt>Locate "Task Manager" under "System" on the Whiskermenu and click on it</dt> for coherence sake.