Merge lp:~elementary-pantheon/wingpanel-indicator-network/icons-24 into lp:~wingpanel-devs/wingpanel-indicator-network/trunk

[Danielle Foré]

Use 24px icons

We want to use 24px icons here because we have some very wide icons like the cell signal icons and also the wireless network offline icon is slightly wider than 16px.

[David Hewitt (davidmhewitt)]

I know this isn't a problem with this merge request, per-se. But, this causes an issue with the size of the icon when I connect to a VPN on my wireless connection. The normal wireless symbol without the padlock (i.e. not connected to a VPN) is a normal size. Then when I connect to a VPN, the icon grows.

I'll send you some screenshots on Slack to illustrate, but it looks a bit messy, so I don't think this should be merged for now.

review: Disapprove

[David Hewitt (davidmhewitt)]

This looks good now with the latest revision of the icons from git.

review: Approve

=== modified file 'src/Widgets/DisplayWidget.vala'
--- src/Widgets/DisplayWidget.vala	2017-02-08 19:07:09 +0000
+++ src/Widgets/DisplayWidget.vala	2017-02-25 16:50:59 +0000
@@ -29,6 +29,7 @@
     construct {
         image = new Gtk.Image ();
         image.icon_name = "network-wired-symbolic";
+        image.icon_size = Gtk.IconSize.LARGE_TOOLBAR;
 
         pack_start (image);
     }