Merge lp:~elementary-pantheon/switchboard/remove-view-class into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Danielle Foré
Status: Merged
Approved by: Corentin Noël
Approved revision: 574
Merged at revision: 574
Proposed branch: lp:~elementary-pantheon/switchboard/remove-view-class
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 18 lines (+1/-8)
1 file modified
src/CategoryView.vala (+1/-8)
To merge this branch: bzr merge lp:~elementary-pantheon/switchboard/remove-view-class
Reviewer Review Type Date Requested Status
Corentin Noël Approve
Review via email: mp+277640@code.launchpad.net

Commit message

remove view class from iconview instead of hard coding background color

Description of the change

Do in 1 line what the old code did with many

To post a comment you must log in.
574. By Danielle Foré

remove view class instead of hardcode background color

Revision history for this message
Corentin Noël (tintou) wrote :

Much better without CSS in Switchboard!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/CategoryView.vala'
2--- src/CategoryView.vala 2015-05-28 16:11:51 +0000
3+++ src/CategoryView.vala 2015-11-17 00:58:08 +0000
4@@ -64,14 +64,7 @@
5 category_label.use_markup = true;
6
7 var category_plugs = setup_icon_view ();
8-
9- var bg_css = new Gtk.CssProvider ();
10- try {
11- bg_css.load_from_data ("*{background-color:@background_color;}", -1);
12- category_plugs.get_style_context ().add_provider (bg_css, 20000);
13- } catch (Error e) {
14- critical (e.message);
15- }
16+ category_plugs.get_style_context ().remove_class (Gtk.STYLE_CLASS_VIEW);
17
18 var grid = new Gtk.Grid ();
19

Subscribers

People subscribed via source and target branches