Merge lp:~elementary-pantheon/switchboard-plug-pantheon-shell/even-top-margin into lp:~elementary-apps/switchboard-plug-pantheon-shell/trunk

Proposed by Danielle Foré
Status: Merged
Approved by: Corentin Noël
Approved revision: 555
Merged at revision: 556
Proposed branch: lp:~elementary-pantheon/switchboard-plug-pantheon-shell/even-top-margin
Merge into: lp:~elementary-apps/switchboard-plug-pantheon-shell/trunk
Diff against target: 81 lines (+8/-12)
4 files modified
src/Views/Dock.vala (+0/-2)
src/Views/HotCorners.vala (+0/-2)
src/Views/Wallpaper.vala (+7/-7)
src/desktop-plug.vala (+1/-1)
To merge this branch: bzr merge lp:~elementary-pantheon/switchboard-plug-pantheon-shell/even-top-margin
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+317278@code.launchpad.net

Commit message

* Remove top margins from individual panes
* Double space around the view switcher
* Place a separator above the wallpaper flowbox to give it upper bounds
* Re-color flowbox with the view class
* Make wallpaper view a grid subclass

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Views/Dock.vala'
2--- src/Views/Dock.vala 2017-02-11 23:12:13 +0000
3+++ src/Views/Dock.vala 2017-02-15 02:31:39 +0000
4@@ -29,8 +29,6 @@
5 column_spacing = 12;
6 halign = Gtk.Align.CENTER;
7 row_spacing = 6;
8- margin = 24;
9- margin_top = 64;
10
11 var icon_size = new Granite.Widgets.ModeButton ();
12 icon_size.append_text (_("Small"));
13
14=== modified file 'src/Views/HotCorners.vala'
15--- src/Views/HotCorners.vala 2017-02-08 19:25:20 +0000
16+++ src/Views/HotCorners.vala 2017-02-15 02:31:39 +0000
17@@ -23,9 +23,7 @@
18 construct {
19 column_spacing = 12;
20 row_spacing = 24;
21- margin = 32;
22 halign = Gtk.Align.CENTER;
23- valign = Gtk.Align.CENTER;
24
25 var expl = new Gtk.Label (_("When the cursor enters the corner of the display:"));
26 expl.get_style_context ().add_class ("h4");
27
28=== modified file 'src/Views/Wallpaper.vala'
29--- src/Views/Wallpaper.vala 2017-02-14 19:30:26 +0000
30+++ src/Views/Wallpaper.vala 2017-02-15 02:31:39 +0000
31@@ -77,7 +77,7 @@
32 public abstract void set_background_file (string filename) throws IOError;
33 }
34
35-public class Wallpaper : Gtk.EventBox {
36+public class Wallpaper : Gtk.Grid {
37 // name of the default-wallpaper-link that we can prevent loading it again
38 // (assumes that the defaultwallpaper is also in the system wallpaper directory)
39 static string DEFAULT_LINK = "file://%s/elementaryos-default".printf (SYSTEM_BACKGROUNDS_PATH);
40@@ -121,10 +121,12 @@
41 warning (e.message);
42 }
43
44+ var separator = new Gtk.Separator (Gtk.Orientation.HORIZONTAL);
45+
46 wallpaper_view = new Gtk.FlowBox ();
47 wallpaper_view.activate_on_single_click = true;
48 wallpaper_view.column_spacing = wallpaper_view.row_spacing = 6;
49- wallpaper_view.margin = 12;
50+ wallpaper_view.get_style_context ().add_class (Gtk.STYLE_CLASS_VIEW);
51 wallpaper_view.homogeneous = true;
52 wallpaper_view.selection_mode = Gtk.SelectionMode.SINGLE;
53 wallpaper_view.child_activated.connect (update_checked_wallpaper);
54@@ -179,11 +181,9 @@
55 actionbar.pack_end (color_button);
56 actionbar.pack_end (combo);
57
58- var grid = new Gtk.Grid ();
59- grid.margin_top = 24;
60- grid.attach (scrolled, 0, 0, 1, 1);
61- grid.attach (actionbar, 0, 1, 1, 1);
62- add (grid);
63+ attach (separator, 0, 0, 1, 1);
64+ attach (scrolled, 0, 1, 1, 1);
65+ attach (actionbar, 0, 2, 1, 1);
66 }
67
68 private void load_settings () {
69
70=== modified file 'src/desktop-plug.vala'
71--- src/desktop-plug.vala 2016-12-21 18:48:26 +0000
72+++ src/desktop-plug.vala 2017-02-15 02:31:39 +0000
73@@ -53,7 +53,7 @@
74 var stack_switcher = new Gtk.StackSwitcher ();
75 stack_switcher.stack = stack;
76 stack_switcher.halign = Gtk.Align.CENTER;
77- stack_switcher.margin_top = 12;
78+ stack_switcher.margin = 24;
79
80 main_grid.attach (stack_switcher, 0, 0, 1, 1);
81 main_grid.attach (stack, 0, 1, 1, 1);

Subscribers

People subscribed via source and target branches