Pantheon Polkit Agent

Merge lp:~elementary-pantheon/pantheon-agent-polkit/align-identity-combo into lp:~elementary-pantheon/pantheon-agent-polkit/trunk

  1. align-identity-combo
  2. Merge into trunk
Proposed by Danielle Foré
Status: Merged
Approved by: Adam Bieńkowski
Approved revision: 62
Merged at revision: 62
Proposed branch: lp:~elementary-pantheon/pantheon-agent-polkit/align-identity-combo
Merge into: lp:~elementary-pantheon/pantheon-agent-polkit/trunk
Diff against target: 19 lines (+1/-5)
1 file modified
src/PolkitDialog.vala (+1/-5)
To merge this branch: bzr merge lp:~elementary-pantheon/pantheon-agent-polkit/align-identity-combo
Reviewer Review Type Date Requested Status
Adam Bieńkowski (community) code / testing Approve
Review via email: mp+314774@code.launchpad.net

Commit message

Remove identity label to align identity combo with password entry

To post a comment you must log in.
Revision history for this message
Adam Bieńkowski (donadigo) wrote :

Looks great. Thanks.

review: Approve (code / testing)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/PolkitDialog.vala'
2--- src/PolkitDialog.vala 2016-10-11 17:07:54 +0000
3+++ src/PolkitDialog.vala 2017-01-15 00:37:17 +0000
4@@ -88,15 +88,11 @@
5 idents_combo.add_attribute (render, "text", 0);
6 idents_combo.set_id_column (0);
7
8- identity_label = new Gtk.Label (_("Identity:"));
9- identity_label.halign = Gtk.Align.END;
10-
11 var credentials_grid = new Gtk.Grid ();
12 credentials_grid.column_spacing = 12;
13 credentials_grid.row_spacing = 6;
14 credentials_grid.margin_top = 12;
15- credentials_grid.attach (identity_label, 0, 0, 1, 1);
16- credentials_grid.attach (idents_combo, 1, 0, 1, 1);
17+ credentials_grid.attach (idents_combo, 0, 0, 1, 1);
18 credentials_grid.attach (password_entry, 0, 2, 1, 1);
19 credentials_grid.attach (feedback_revealer, 0, 3, 1, 1);
20

Subscribers

People subscribed via source and target branches