Merge lp:~elementary-pantheon/granite/storagebar-hidpi into lp:~elementary-pantheon/granite/granite

Proposed by Danielle Foré
Status: Merged
Approved by: Corentin Noël
Approved revision: 951
Merged at revision: 951
Proposed branch: lp:~elementary-pantheon/granite/storagebar-hidpi
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 21 lines (+2/-2)
1 file modified
lib/Widgets/StorageBar.vala (+2/-2)
To merge this branch: bzr merge lp:~elementary-pantheon/granite/storagebar-hidpi
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Review via email: mp+298076@code.launchpad.net

Commit message

StorageBar: Fix double size in HiDPI

Description of the change

We don't need to multiply by scale here, Gtk already doubles the padding values in HiDPI. In trunk, the widget is twice as large as it should be.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/StorageBar.vala'
2--- lib/Widgets/StorageBar.vala 2015-06-16 17:39:23 +0000
3+++ lib/Widgets/StorageBar.vala 2016-06-22 02:32:33 +0000
4@@ -297,7 +297,7 @@
5 base.get_preferred_width (out minimum_width, out natural_width);
6 var context = get_style_context ();
7 var padding = context.get_padding (get_state_flags ());
8- minimum_width = int.max ((padding.left + padding.right) * context.get_scale (), minimum_width);
9+ minimum_width = int.max (padding.left + padding.right, minimum_width);
10 minimum_width = int.max (1, minimum_width);
11 natural_width = int.max (minimum_width, natural_width);
12 }
13@@ -306,7 +306,7 @@
14 base.get_preferred_height (out minimum_height, out natural_height);
15 var context = get_style_context ();
16 var padding = context.get_padding (get_state_flags ());
17- minimum_height = int.max ((padding.top + padding.bottom) * context.get_scale (), minimum_height);
18+ minimum_height = int.max (padding.top + padding.bottom, minimum_height);
19 minimum_height = int.max (1, minimum_height);
20 natural_height = int.max (minimum_height, natural_height);
21 }

Subscribers

People subscribed via source and target branches