Granite

Merge lp:~elementary-pantheon/granite/circular into lp:~elementary-pantheon/granite/granite

  1. circular
  2. Merge into granite
Proposed by Danielle Foré
Status: Merged
Approved by: Danielle Foré
Approved revision: 936
Merged at revision: 936
Proposed branch: lp:~elementary-pantheon/granite/circular
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 12 lines (+1/-1)
1 file modified
lib/Widgets/AboutDialog.vala (+1/-1)
To merge this branch: bzr merge lp:~elementary-pantheon/granite/circular
Reviewer Review Type Date Requested Status
Ben (community) Approve
elementary Pantheon team Pending
Review via email: mp+291701@code.launchpad.net

Commit message

AboutDialog:
* Use "circular" not "circular-button"

Description of the change

Ben pointed out that Adwaita is actually just using "circular" https://github.com/GNOME/gtk/blob/master/gtk/theme/Adwaita/_common.scss#L4273

Looks like the circular-button in gtk3-widget-factory is a red herring

To post a comment you must log in.
Revision history for this message
Ben (benwaffle) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/AboutDialog.vala'
2--- lib/Widgets/AboutDialog.vala 2016-04-11 21:02:53 +0000
3+++ lib/Widgets/AboutDialog.vala 2016-04-13 01:04:56 +0000
4@@ -77,7 +77,7 @@
5
6 /* help button */
7 help_button = new Button.with_label ("?");
8- help_button.get_style_context ().add_class ("circular-button");
9+ help_button.get_style_context ().add_class ("circular");
10
11 help_button.halign = Gtk.Align.CENTER;
12 help_button.clicked.connect (() => { activate_link(help); });

Subscribers

People subscribed via source and target branches