Granite

Merge lp:~elementary-os/granite/deprecate-statusbar-widget into lp:~elementary-pantheon/granite/granite

  1. deprecate-statusbar-widget
  2. Merge into granite
Proposed by Sergey "Shnatsel" Davidoff
Status: Merged
Approved by: Danielle Foré
Approved revision: 734
Merged at revision: 734
Proposed branch: lp:~elementary-os/granite/deprecate-statusbar-widget
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 16 lines (+1/-1)
1 file modified
lib/Widgets/StatusBar.vala (+1/-1)
To merge this branch: bzr merge lp:~elementary-os/granite/deprecate-statusbar-widget
Reviewer Review Type Date Requested Status
Victor Martinez (community) Approve
Review via email: mp+220212@code.launchpad.net

Commit message

Deprecate Granite.StatusBar in favor of Gtk.ActionBar

Description of the change

Deprecate Granite.StatusBar in favor of Gtk.ActionBar; Noise is already migrated to Gtk.ActionBar, so the widgets are indeed equivalent.

I have verified that this change does make the widget entry strikethrough in Valadoc.

To post a comment you must log in.
Revision history for this message
Victor Martinez (victored) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/StatusBar.vala'
2--- lib/Widgets/StatusBar.vala 2013-03-21 12:23:37 +0000
3+++ lib/Widgets/StatusBar.vala 2014-05-20 09:01:30 +0000
4@@ -24,6 +24,7 @@
5 *
6 * It supports adding widgets at its left and right sides.
7 */
8+[Deprecated (replacement = "Gtk.ActionBar", since = "0.3")]
9 public class Granite.Widgets.StatusBar : Gtk.Toolbar {
10 private const int ITEM_SPACING = 3;
11
12@@ -110,4 +111,3 @@
13 status_label.set_text (text);
14 }
15 }
16-

Subscribers

People subscribed via source and target branches