Merge lp:~elementary-dev-community/pantheon-terminal/zoom-in-out into lp:~elementary-apps/pantheon-terminal/trunk

[David Gomes]

Implemented zooming in/out of the terminal.

[Victor Martinez (victored)]

This looks perfect to me David. It would be even better if it triggered size_increment() and size_decrement() from the scroll event while CTRL is pressed, but that's worth another branch maybe :)

review: Approve

[Victor Martinez (victored)]

The terminal is printing some interesting warnings:

[Gtk] Unable to parse accelerator '<Control>zero' for action 'ZoomDefault'

And this appears when CTRL + (numpad's) +/- are pressed:

[_LOG_LEVEL_WARN 13:30:33.999544] [GLib-GObject] g_object_notify: object class `PantheonTerminalTerminalWidget' has no property named `font-scale'

Could it be that libvte has this as a built-in feature tied to those keys?

review: Needs Fixing

[lp:~elementary-dev-community/pantheon-terminal/zoom-in-out]

349. By David Gomes on 2012-09-13

Implemented NUMPAD keys for zooming in/out of terminal.

[David Gomes (davidgomes)]

> The terminal is printing some interesting warnings:
>
> [Gtk] Unable to parse accelerator '<Control>zero' for action 'ZoomDefault'
>
>
> And this appears when CTRL + (numpad's) +/- are pressed:
>
> [_LOG_LEVEL_WARN 13:30:33.999544] [GLib-GObject] g_object_notify: object class
> `PantheonTerminalTerminalWidget' has no property named `font-scale'
>
> Could it be that libvte has this as a built-in feature tied to those keys?

I'm not getting that output, but the latest revision implements KP_Add and KP_Subtract to also zoom in/out of the terminal.

Regarding the "<Control>zero", I also tried "<Control>0" and "<Control>Zero" but none of those are working in the accel_group. Any ideas?

[lp:~elementary-dev-community/pantheon-terminal/zoom-in-out]

350. By David Gomes on 2012-09-14

Removed Ctrl-0 due to parsing error.

[Victor Martinez (victored)]

David, I couldn't find documentation about the "<Control>0" issue. I think it'd be more convenient to simply remove it from the code and merge the branch. Everything else works perfectly. And thank you for adding support for KP_Add and KP_Subtract. You rock!

review: Approve