Merge lp:~elementary-dev-community/pantheon-terminal/fix-1329550 into lp:~elementary-apps/pantheon-terminal/trunk
Proposed by
Cameron Norman
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 601 | ||||
Proposed branch: | lp:~elementary-dev-community/pantheon-terminal/fix-1329550 | ||||
Merge into: | lp:~elementary-apps/pantheon-terminal/trunk | ||||
Diff against target: |
72 lines (+11/-5) 3 files modified
data/pantheon-terminal.desktop (+5/-1) src/PantheonTerminal.vala (+6/-3) src/PantheonTerminalWindow.vala (+0/-1) |
||||
To merge this branch: | bzr merge lp:~elementary-dev-community/pantheon-terminal/fix-1329550 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphael Isemann (community) | functionality, code-style | Approve | |
David Gomes (community) | Approve | ||
Review via email: mp+229683@code.launchpad.net |
Commit message
Adds an --about (-a) command line option and a corresponding quicklist item
Description of the change
This adds an --about (-a) command line option and a corresponding quicklist item. It leaves the item in the right click menu intact, so that users on desktops that do not implement quicklists can still access the about dialog via GUI.
To post a comment you must log in.
1. Instead of
43 stdout.printf ("pantheon- terminal: ERROR: " + e.message + "\n");
44
45 return 0;
use
error (e.message);
2. Not sure about the relevant part in the code, but the dark GTK+ theme isn't active when you start the About-Dialog from the quicklist and no terminal-instance is already running. In this case the about-window uses the normal GTK+ theme (so, a white window in elementary).