Switchboard

Merge lp:~elementary-apps/switchboard/sep-padding into lp:~elementary-pantheon/switchboard/switchboard

  1. sep-padding
  2. Merge into switchboard
Proposed by Danielle Foré
Status: Merged
Approved by: David Gomes
Approved revision: 403
Merged at revision: 403
Proposed branch: lp:~elementary-apps/switchboard/sep-padding
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 18 lines (+2/-0)
1 file modified
src/CategoryView.vala (+2/-0)
To merge this branch: bzr merge lp:~elementary-apps/switchboard/sep-padding
Reviewer Review Type Date Requested Status
David Gomes (community) Approve
Review via email: mp+188233@code.launchpad.net

Commit message

Add margins to category separators.

Description of the change

Adds 8px padding between category labels and seps and adds 12px margins between seps and right side of the window

To post a comment you must log in.
Revision history for this message
David Gomes (davidgomes) wrote :

http://imgur.com/a/Vii17

Seems the same to me?

Revision history for this message
David Gomes (davidgomes) wrote :

Got it, much better.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/CategoryView.vala'
2--- src/CategoryView.vala 2013-01-08 15:21:51 +0000
3+++ src/CategoryView.vala 2013-09-29 18:36:00 +0000
4@@ -39,6 +39,7 @@
5
6 var category_label = new Gtk.Label ("<big><b>" + _(category_names[i]) + "</b></big>");
7 category_label.margin_left = 12;
8+ category_label.margin_right = 8;
9 var filtered = new Gtk.TreeModelFilter (store, null);
10 filtered.set_visible_column(3);
11 filtered.refilter ();
12@@ -66,6 +67,7 @@
13 // Always add a Seperator
14 var h_separator = new Gtk.Separator (Gtk.Orientation.HORIZONTAL);
15 h_separator.set_hexpand (true);
16+ h_separator.margin_right = 12;
17 grid.attach (category_label, 0, 0, 1, 1);
18 grid.attach (h_separator, 1, 0, 1, 1); // expand, fill, padding´
19

Subscribers

People subscribed via source and target branches