Code review comment for lp:~elementary-apps/switchboard/fix-bug-1039269

Revision history for this message
Akshay Shekher (voldyman) wrote :

the code look fine, i just a few suggestions.

rename the file from Buttons.vala to NavigationButton.vala, it'll look less generic.

In the signal search_box.changed you partially changed the closure, you could also fix the spacing of the bracket on line 294.

since when are we giving the copyright to elementary LLC instead of elementary Developers or <insert project name here> developers?

review: Approve

« Back to merge proposal