Merge lp:~elementary-apps/switchboard/about-in-quicklist into lp:~elementary-pantheon/switchboard/switchboard

[Julián Unrrein]

Add option to show the About dialog in the static quicklist (.desktop file).

Add option to show the About dialog in the static quicklist (.desktop file).

This needs "make pot" after merging.

[Julián Unrrein (junrrein)]

Adding elementar-design to check what the string should be.

[David Gomes (davidgomes)]

Approving. Which string Julian, "About"?

review: Approve

[Cody Garver (codygarver)]

He might mean "About Switchboard" vs "About System Settings"

[Julián Unrrein (junrrein)]

Or just simply "About".

[Danielle Foré (danrabbit)]

should be "About System Settings" to be consistent with how Switchboard is presented and to follow the precedence that Files already set.

[Julián Unrrein (junrrein)]

String changed, should be good to go.

[Julián Unrrein (junrrein)]

I dropped the TargetEnvironment line since it seems the spec doesn't require them (http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#extra-actions) and doing so doesn't break the quicklist for either Pantheon or Unity.

[RabbitBot (rabbitbot-a)]

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

[Cody Garver (codygarver)]

review: Approve

[Rico Tzschichholz (ricotz)]

@junrrein: You even linked to the spec, but why not using the proper syntax?

[Desktop Entry]
Version=1.0
Type=Application
Name=Foo Viewer
Comment=The best viewer for Foo objects available!
TryExec=fooview
Exec=fooview %F
Icon=fooview
MimeType=image/x-foo;
Actions=Gallery;Create;

[Desktop Action Gallery]
Exec=fooview --gallery
Name=Browse Gallery

[Desktop Action Create]
Exec=fooview --create-new
Name=Create a new Foo!
Icon=fooview-new

[Julián Unrrein (junrrein)]

@ricotz: Because I merely limited myself to copy the syntax already used in other projects.

Thanks for the insight. I will resubmit this branch using the fd.o syntax and update my other branches accordingly.

[Rico Tzschichholz (ricotz)]

Hmm, ok.

Just as a note, there is also the way of using "gapplication" to trigger an action of DbusActivatebale apps, like polari does:

[Desktop Action connections]
Name=Show connections
Exec=gapplication action org.gnome.Polari connections

=== modified file 'data/switchboard.desktop'
--- data/switchboard.desktop	2014-04-14 20:39:34 +0000
+++ data/switchboard.desktop	2014-08-02 19:13:42 +0000
@@ -8,4 +8,10 @@
 Categories=GNOME;GTK;System;
 X-GNOME-Keywords=Center;Control;Panel;Preferences;System;
 X-AppInstall-Keywords=Center;Control;Panel;Preferences;System;
-X-GNOME-Gettext-Domain=switchboard
\ No newline at end of file
+X-GNOME-Gettext-Domain=switchboard
+
+X-Ayatana-Desktop-Shortcuts=AboutDialog
+
+[AboutDialog Shortcut Group]
+Name=About System Settings
+Exec=switchboard --about
\ No newline at end of file

=== modified file 'src/Switchboard.vala'
--- src/Switchboard.vala	2014-07-28 09:33:03 +0000
+++ src/Switchboard.vala	2014-08-02 19:13:42 +0000
@@ -365,7 +365,7 @@
 
             if (search_box.sensitive)
                 search_box.has_focus = true;
-                
+
             return true;
         }
 
@@ -491,4 +491,5 @@
 #if TRANSLATION
 _("Change system and user settings");
 _("Center;Control;Panel;Preferences;System;");
+_("About System Settings");
 #endif