Merge lp:~elementary-apps/switchboard-plug-about/trunk into lp:~alcinnz/switchboard-plug-about/setting-uri

Proposed by Adrian Cochrane
Status: Rejected
Rejected by: Adrian Cochrane
Proposed branch: lp:~elementary-apps/switchboard-plug-about/trunk
Merge into: lp:~alcinnz/switchboard-plug-about/setting-uri
Diff against target: 0 lines
To merge this branch: bzr merge lp:~elementary-apps/switchboard-plug-about/trunk
Reviewer Review Type Date Requested Status
Danielle Foré (community) Disapprove
Adrian Cochrane Pending
Review via email: mp+319642@code.launchpad.net

Description of the change

Add support for your "Preferences Opening Specification" proposal.

As that proposal didn't specify any URIs to this settings pane, I chose settings://about.
Could be a useful URI for the desktop to open.

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

This merge request is backwards :p You need to propose merging your branch into trunk not merging trunk into your branch

review: Disapprove
Revision history for this message
Adrian Cochrane (alcinnz) wrote :

Sorry, got confused with Launchpad's interface. I will redo this today.

Unmerged revisions

443. By Neal Gompa

Rework os-release(5) parsing to be less brittle.

Since /etc/os-release is effectively a set of key-value pairs, we'll just read the whole thing and import it into a HashMap.

This allows us to reference arbitrary entries from the file and set variables with that data accordingly.

442. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

441. By Danielle Foré

Rewrite settings restore dialog as its own widget

440. By Launchpad Translations on behalf of elementary-apps

Launchpad automatic translations update.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to all changes: