Merge lp:~elementary-apps/pantheon-terminal/fix-0.3.0-release into lp:~elementary-apps/pantheon-terminal/trunk
Status: | Rejected |
---|---|
Rejected by: | Sergey "Shnatsel" Davidoff |
Proposed branch: | lp:~elementary-apps/pantheon-terminal/fix-0.3.0-release |
Merge into: | lp:~elementary-apps/pantheon-terminal/trunk |
Diff against target: |
58 lines (+7/-6) 2 files modified
CMakeLists.txt (+6/-5) INSTALL (+1/-1) |
To merge this branch: | bzr merge lp:~elementary-apps/pantheon-terminal/fix-0.3.0-release |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
elementary Apps team | Pending | ||
Review via email: mp+221327@code.launchpad.net |
Description of the change
Fix a number of trivial issues in 0.3.0 release:
- Set proper GTK and valac version requirements (they got bumped because of the HeaderBar)
- Fix config.vala being generated in the source tree and making its way into release tarballs generated with "make dist" and messing up build procedures in other distros
This branch makes a new release 0.3.1 to distinguish it from the previous 0.3.0.
CMake magic and Valac bump are done according to Rico's advice.
Unmerged revisions
- 579. By Sergey "Shnatsel" Davidoff
-
Really fix CMake issues this time, hopefully
- 578. By Sergey "Shnatsel" Davidoff
-
Rename 0.3.1 to 0.3.0.1
- 577. By Sergey "Shnatsel" Davidoff
-
Release 0.3.1
- 576. By Sergey "Shnatsel" Davidoff
-
Bump GTK requirement to 3.9.10 and valac to 0.22.0 because of HeaderBar
- 575. By Sergey "Shnatsel" Davidoff
-
Fix config.vala.cmake being generated in source tree and messing up Debian build procedures
Uhm. Turns out this breaks build:
$ make config. vala', needed by `src/Settings.c'. Stop. pantheon- terminal. dir/all] Error 2
make[2]: *** No rule to make target `../src/
make[1]: *** [CMakeFiles/
make: *** [all] Error 2