Merge lp:~elementary-apps/pantheon-terminal/fix-0.3.0-release into lp:~elementary-apps/pantheon-terminal/trunk

Proposed by Sergey "Shnatsel" Davidoff
Status: Rejected
Rejected by: Sergey "Shnatsel" Davidoff
Proposed branch: lp:~elementary-apps/pantheon-terminal/fix-0.3.0-release
Merge into: lp:~elementary-apps/pantheon-terminal/trunk
Diff against target: 58 lines (+7/-6)
2 files modified
CMakeLists.txt (+6/-5)
INSTALL (+1/-1)
To merge this branch: bzr merge lp:~elementary-apps/pantheon-terminal/fix-0.3.0-release
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+221327@code.launchpad.net

Description of the change

Fix a number of trivial issues in 0.3.0 release:
 - Set proper GTK and valac version requirements (they got bumped because of the HeaderBar)
 - Fix config.vala being generated in the source tree and making its way into release tarballs generated with "make dist" and messing up build procedures in other distros

This branch makes a new release 0.3.1 to distinguish it from the previous 0.3.0.

CMake magic and Valac bump are done according to Rico's advice.

To post a comment you must log in.
578. By Sergey "Shnatsel" Davidoff

Rename 0.3.1 to 0.3.0.1

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Uhm. Turns out this breaks build:

$ make
make[2]: *** No rule to make target `../src/config.vala', needed by `src/Settings.c'. Stop.
make[1]: *** [CMakeFiles/pantheon-terminal.dir/all] Error 2
make: *** [all] Error 2

579. By Sergey "Shnatsel" Davidoff

Really fix CMake issues this time, hopefully

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Dammit, I suck at CMake. This doesn't work, whatever I do.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Unmerged revisions

579. By Sergey "Shnatsel" Davidoff

Really fix CMake issues this time, hopefully

578. By Sergey "Shnatsel" Davidoff

Rename 0.3.1 to 0.3.0.1

577. By Sergey "Shnatsel" Davidoff

Release 0.3.1

576. By Sergey "Shnatsel" Davidoff

Bump GTK requirement to 3.9.10 and valac to 0.22.0 because of HeaderBar

575. By Sergey "Shnatsel" Davidoff

Fix config.vala.cmake being generated in source tree and messing up Debian build procedures

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-05-25 06:03:15 +0000
3+++ CMakeLists.txt 2014-05-29 08:11:18 +0000
4@@ -16,13 +16,14 @@
5 set (PKGDATADIR "${DATADIR}/pantheon-terminal")
6 set (GETTEXT_PACKAGE "pantheon-terminal")
7 set (RELEASE_NAME "Fast and connected.")
8-set (VERSION "0.3.0")
9+set (VERSION "0.3.0.1")
10 set (VERSION_INFO "Release")
11 set (CMAKE_C_FLAGS "-ggdb")
12 set (PREFIX ${CMAKE_INSTALL_PREFIX})
13 set (DOLLAR "$")
14+set (CONFIG_FILE ${CMAKE_CURRENT_BINARY_DIR}/config.vala)
15
16-configure_file (${CMAKE_SOURCE_DIR}/src/config.vala.cmake ${CMAKE_SOURCE_DIR}/src/config.vala)
17+configure_file (${CMAKE_SOURCE_DIR}/src/config.vala.cmake ${CONFIG_FILE})
18 add_definitions (-DGETTEXT_PACKAGE=\"${GETTEXT_PACKAGE}\")
19
20 # Comment this out to enable C compiler warnings
21@@ -40,7 +41,7 @@
22 find_package (PkgConfig)
23 pkg_check_modules (DEPS REQUIRED
24 gthread-2.0
25- gtk+-3.0
26+ gtk+-3.0>=3.9.10
27 granite>=0.3.0
28 vte-2.90
29 libnotify
30@@ -53,7 +54,7 @@
31
32 find_package (Vala REQUIRED)
33 include (ValaVersion)
34-ensure_vala_version ("0.16.0" MINIMUM)
35+ensure_vala_version ("0.22.0" MINIMUM)
36
37 include (ValaPrecompile)
38 vala_precompile (VALA_C
39@@ -62,7 +63,7 @@
40 src/PantheonTerminalWindow.vala
41 src/TerminalWidget.vala
42 src/ForegroundProcessDialog.vala
43- src/config.vala
44+ ${CONFIG_FILE}
45 PACKAGES
46 vte-2.90
47 granite
48
49=== modified file 'INSTALL'
50--- INSTALL 2013-09-30 20:08:22 +0000
51+++ INSTALL 2014-05-29 08:11:18 +0000
52@@ -8,4 +8,4 @@
53 cd build/
54 make install #Might need sudo
55
56-To launch the Terminal locally (for development purposes), use "./pantheon-terminal" from the build/ directory.
57\ No newline at end of file
58+To launch the Terminal locally (for development purposes), use "./pantheon-terminal" from the build/ directory.

Subscribers

People subscribed via source and target branches