Merge lp:~elementary-apps/pantheon-mail/geary-to-mail into lp:~elementary-apps/pantheon-mail/trunk

Proposed by Danielle Foré
Status: Merged
Approved by: kay van der Zander
Approved revision: 1875
Merged at revision: 1879
Proposed branch: lp:~elementary-apps/pantheon-mail/geary-to-mail
Merge into: lp:~elementary-apps/pantheon-mail/trunk
Diff against target: 40 lines (+6/-6)
3 files modified
data/geary-attach.contract.in (+2/-2)
data/geary.desktop.in (+3/-3)
src/client/application/geary-application.vala (+1/-1)
To merge this branch: bzr merge lp:~elementary-apps/pantheon-mail/geary-to-mail
Reviewer Review Type Date Requested Status
kay van der Zander (community) Approve
Review via email: mp+278100@code.launchpad.net

Commit message

Change Geary to Mail

To post a comment you must log in.
Revision history for this message
kay van der Zander (kay20) wrote :

Looks good. Perhaps change APP_ID into org.pantheon.mail?

review: Needs Information
Revision history for this message
Danielle Foré (danrabbit) wrote :

Changing the APP_ID requires moving the gsettings schemas. I'm not sure if we really want to do that yet. I think it's outside the scope of this branch, which is only an aesthetic change and not a technical one

1875. By Danielle Foré

geary is now mail

Revision history for this message
kay van der Zander (kay20) wrote :

Yes i agree

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/geary-attach.contract.in'
2--- data/geary-attach.contract.in 2014-10-10 21:51:05 +0000
3+++ data/geary-attach.contract.in 2015-11-23 01:35:06 +0000
4@@ -1,6 +1,6 @@
5 [Contractor Entry]
6-_Name=Send by email
7+_Name=Send by Email
8 Icon=mail-send
9-_Description=Send files using Geary
10+_Description=Send files using Mail
11 MimeType=!inode;
12 Exec=geary-attach %F
13
14=== modified file 'data/geary.desktop.in'
15--- data/geary.desktop.in 2015-11-19 13:04:51 +0000
16+++ data/geary.desktop.in 2015-11-23 01:35:06 +0000
17@@ -1,7 +1,7 @@
18 [Desktop Entry]
19-_Name=Geary
20-_GenericName=Mail Client
21-_X-GNOME-FullName=Geary Mail
22+_Name=Mail
23+_GenericName=Mail
24+_X-GNOME-FullName=Mail
25 _Comment=Send and receive email
26 _Keywords=Email;E-mail;Mail;
27 Icon=internet-mail
28
29=== modified file 'src/client/application/geary-application.vala'
30--- src/client/application/geary-application.vala 2015-03-26 22:21:11 +0000
31+++ src/client/application/geary-application.vala 2015-11-23 01:35:06 +0000
32@@ -12,7 +12,7 @@
33 extern const string GETTEXT_PACKAGE;
34
35 public class GearyApplication : Gtk.Application {
36- public const string NAME = "Geary";
37+ public const string NAME = "Mail";
38 public const string PRGNAME = "geary";
39 public const string APP_ID = "org.yorba.geary";
40 public const string DESCRIPTION = _("Mail Client");

Subscribers

People subscribed via source and target branches