Merge lp:~elementary-apps/pantheon-files/find-function-selection into lp:~elementary-apps/pantheon-files/trunk

[Danielle Foré]

SearchResults.vala:
* Don't enable hover selection
* Properties in alphabetical order, functions at the end
* Don't select headers

Hover select seems to be false by default and I noticed setting it explicitly seemed to break keyboard navigation. So not setting it at all has the intended behavior.

For anyone other than Jeremy viewing this branch, we want to disable hover mouse select because it has the unintended consequence of making it so pressing enter launchers a random result (the one under your mouse) instead of the top result.

[Jeremy Wootten (jeremywootten)]

Works as expected.

review: Approve (code, function)

=== modified file 'libwidgets/View/SearchResults.vala'
--- libwidgets/View/SearchResults.vala	2017-05-06 17:57:48 +0000
+++ libwidgets/View/SearchResults.vala	2017-05-06 18:18:05 +0000
@@ -122,11 +122,15 @@
             scroll.hscrollbar_policy = Gtk.PolicyType.NEVER;
 
             view = new Gtk.TreeView ();
-            view.get_selection ().set_mode (Gtk.SelectionMode.BROWSE);
             view.headers_visible = false;
+            view.level_indentation = 12;
             view.show_expanders = false;
-            view.level_indentation = 12;
-            view.set_hover_selection (true);
+            view.get_selection ().set_mode (Gtk.SelectionMode.BROWSE);
+
+            /* Do not select category headers */
+            view.get_selection ().set_select_function ((selection, list, path, path_selected) => {
+                return path.get_depth () != 0;
+            });
 
             get_style_context ().add_class ("completion-popup");