Merge lp:~elementary-apps/pantheon-calculator/settings-bind into lp:~elementary-apps/pantheon-calculator/trunk

Proposed by Danielle Foré
Status: Merged
Approved by: Cassidy James Blaede
Approved revision: 237
Merged at revision: 237
Proposed branch: lp:~elementary-apps/pantheon-calculator/settings-bind
Merge into: lp:~elementary-apps/pantheon-calculator/trunk
Diff against target: 17 lines (+3/-5)
1 file modified
src/MainWindow.vala (+3/-5)
To merge this branch: bzr merge lp:~elementary-apps/pantheon-calculator/settings-bind
Reviewer Review Type Date Requested Status
Cassidy James Blaede Approve
Review via email: mp+297974@code.launchpad.net

Commit message

Set settings with a bind instead of on window destroy connect

To post a comment you must log in.
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/MainWindow.vala'
2--- src/MainWindow.vala 2016-03-06 17:56:37 +0000
3+++ src/MainWindow.vala 2016-06-21 00:41:11 +0000
4@@ -61,11 +61,9 @@
5 build_titlebar ();
6 build_ui ();
7
8- this.destroy.connect (() => {
9- debug ("saving settings to gsettings");
10- settings.set_boolean ("extended-shown", button_extended.get_active ());
11- settings.set_string ("entry-content", entry.get_text ());
12- });
13+ settings.bind ("extended-shown", button_extended, "active", SettingsBindFlags.DEFAULT);
14+ settings.bind ("entry-content", entry, "text", SettingsBindFlags.DEFAULT);
15+
16 this.key_press_event.connect (key_pressed);
17 }
18

Subscribers

People subscribed via source and target branches