Merge lp:~elementary-apps/granite/deprecate-hinted-entry into lp:~elementary-pantheon/granite/granite

Proposed by Sergey "Shnatsel" Davidoff
Status: Superseded
Proposed branch: lp:~elementary-apps/granite/deprecate-hinted-entry
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 18 lines (+2/-0)
1 file modified
lib/Widgets/Entries.vala (+2/-0)
To merge this branch: bzr merge lp:~elementary-apps/granite/deprecate-hinted-entry
Reviewer Review Type Date Requested Status
Victor Martinez (community) Needs Fixing
Cody Garver Pending
Review via email: mp+214454@code.launchpad.net

This proposal has been superseded by a proposal from 2014-04-19.

Description of the change

Deprecate HintedEntry and SearchBar because GTK has those since 3.6; set deprecated-since to "GTK+ 3.6"

While we're at it, change deprecated-since for StaticNotebook from "0.3" to "GTK+ 3.10" because this deprecation not tied to any Granite version, it's just that GTK implements a similar widget since 3.10

To post a comment you must log in.
Revision history for this message
Victor Martinez (victored) wrote :

"because this deprecation not tied to any Granite version, it's just that GTK implements a similar widget since 3.10"

The GTK+ version is not relevant here. Just the Granite version when the symbols are deprecated.

As far as GTK+ replacements go, the "replacement" field already does enough.

review: Needs Fixing
716. By David Gomes

Fixes since values according to Victor's review.

Revision history for this message
David Gomes (davidgomes) wrote :

Fixed according to Victor's review.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/Entries.vala'
2--- lib/Widgets/Entries.vala 2013-08-22 15:06:38 +0000
3+++ lib/Widgets/Entries.vala 2014-04-19 13:46:21 +0000
4@@ -26,6 +26,7 @@
5 /**
6 * A text entry space with hint and clear icon
7 */
8+ [Deprecated (since = "0.3", replacement = "Gtk.Entry.placeholder_text")]
9 public class HintedEntry : Gtk.Entry {
10 public bool has_clear_icon { get; set; default = false; }
11
12@@ -84,6 +85,7 @@
13 /**
14 * A searchbar with hint-text.
15 */
16+ [Deprecated (since = "0.3", replacement = "Gtk.SearchEntry")]
17 public class SearchBar : HintedEntry {
18 private uint timeout_id = 0;
19

Subscribers

People subscribed via source and target branches