Granite

Merge lp:~elementary-apps/granite/circular-button into lp:~elementary-pantheon/granite/granite

  1. circular-button
  2. Merge into granite
Proposed by Danielle Foré
Status: Merged
Approved by: Danielle Foré
Approved revision: 935
Merged at revision: 935
Proposed branch: lp:~elementary-apps/granite/circular-button
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 12 lines (+1/-1)
1 file modified
lib/Widgets/AboutDialog.vala (+1/-1)
To merge this branch: bzr merge lp:~elementary-apps/granite/circular-button
Reviewer Review Type Date Requested Status
Corentin Noël Approve
Review via email: mp+291559@code.launchpad.net

Commit message

use "circular-button" class instead of "help_button" for wider theme compatibility

Description of the change

Looks like "circular-button" is the class being used in Gtk3-widget-factory, so this gives us wider theme compatibility

To post a comment you must log in.
Revision history for this message
Corentin Noël (tintou) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/AboutDialog.vala'
2--- lib/Widgets/AboutDialog.vala 2014-09-04 12:39:00 +0000
3+++ lib/Widgets/AboutDialog.vala 2016-04-11 21:06:07 +0000
4@@ -77,7 +77,7 @@
5
6 /* help button */
7 help_button = new Button.with_label ("?");
8- help_button.get_style_context ().add_class ("help_button");
9+ help_button.get_style_context ().add_class ("circular-button");
10
11 help_button.halign = Gtk.Align.CENTER;
12 help_button.clicked.connect (() => { activate_link(help); });

Subscribers

People subscribed via source and target branches