Merge lp:~elementary-apps/capnet-assist/bitesize-cleanups into lp:~elementary-apps/capnet-assist/trunk

Proposed by Danielle Foré
Status: Merged
Approved by: Adam Bieńkowski
Approved revision: 100
Merged at revision: 101
Proposed branch: lp:~elementary-apps/capnet-assist/bitesize-cleanups
Merge into: lp:~elementary-apps/capnet-assist/trunk
Diff against target: 65 lines (+22/-22)
1 file modified
src/CaptiveLogin.vala (+22/-22)
To merge this branch: bzr merge lp:~elementary-apps/capnet-assist/bitesize-cleanups
Reviewer Review Type Date Requested Status
Adam Bieńkowski (community) code / testing Approve
Review via email: mp+305288@code.launchpad.net

Commit message

CaptiveLogin.vala:
* Update license header
* return privacy mode without creating a variable
* remove extra comment

To post a comment you must log in.
Revision history for this message
Adam Bieńkowski (donadigo) wrote :

No issues with it.

review: Approve (code / testing)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/CaptiveLogin.vala'
2--- src/CaptiveLogin.vala 2016-09-08 19:50:06 +0000
3+++ src/CaptiveLogin.vala 2016-09-09 01:34:50 +0000
4@@ -1,21 +1,22 @@
5-/***
6- BEGIN LICENSE
7-
8- Copyright (C) 2015 elementary LLC.
9- This program is free software: you can redistribute it and/or modify it
10- under the terms of the GNU Lesser General Public License version 3, as published
11- by the Free Software Foundation.
12-
13- This program is distributed in the hope that it will be useful, but
14- WITHOUT ANY WARRANTY; without even the implied warranties of
15- MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
16- PURPOSE. See the GNU General Public License for more details.
17-
18- You should have received a copy of the GNU General Public License along
19- with this program. If not, see <http://www.gnu.org/licenses/>
20-
21- END LICENSE
22-***/
23+/*
24+* Copyright (c) 2015 - 2016 elementary LLC (http://launchpad.net/capnet-assist)
25+*
26+* This program is free software; you can redistribute it and/or
27+* modify it under the terms of the GNU General Public
28+* License as published by the Free Software Foundation; either
29+* version 2 of the License, or (at your option) any later version.
30+*
31+* This program is distributed in the hope that it will be useful,
32+* but WITHOUT ANY WARRANTY; without even the implied warranty of
33+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
34+* General Public License for more details.
35+*
36+* You should have received a copy of the GNU General Public
37+* License along with this program; if not, write to the
38+* Free Software Foundation, Inc., 59 Temple Place - Suite 330,
39+* Boston, MA 02111-1307, USA.
40+*
41+*/
42
43 public class ValaBrowser : Gtk.ApplicationWindow {
44
45@@ -43,9 +44,8 @@
46
47 bool is_privacy_mode_enabled () {
48 var privacy_settings = new GLib.Settings ("org.gnome.desktop.privacy");
49- bool privacy_mode = !privacy_settings.get_boolean ("remember-recent-files") ||
50- !privacy_settings.get_boolean ("remember-app-usage");
51- return privacy_mode;
52+ return !privacy_settings.get_boolean ("remember-recent-files") ||
53+ !privacy_settings.get_boolean ("remember-app-usage");
54 }
55
56 private void setup_web_view () {
57@@ -243,7 +243,7 @@
58 private void connect_signals () {
59 this.destroy.connect (application.quit);
60 tls_button.toggled.connect (on_tls_button_click);
61- //should title change?
62+
63 web_view.notify["title"].connect ((view, param_spec) => {
64 title_label.set_text (web_view.get_title ());
65 });

Subscribers

People subscribed via source and target branches

to all changes: