Merge lp:~elementary-apps/audience/headerbar into lp:~audience-members/audience/gtk-3.12

Proposed by Danielle Foré
Status: Merged
Approved by: Danielle Foré
Approved revision: 342
Merged at revision: 346
Proposed branch: lp:~elementary-apps/audience/headerbar
Merge into: lp:~audience-members/audience/gtk-3.12
Diff against target: 16 lines (+6/-0)
1 file modified
src/Audience.vala (+6/-0)
To merge this branch: bzr merge lp:~elementary-apps/audience/headerbar
Reviewer Review Type Date Requested Status
Corentin Noël Approve
Victor Martinez (community) Approve
Review via email: mp+218729@code.launchpad.net

Commit message

uses CSD titlebar

Description of the change

use CSD titlebar

To post a comment you must log in.
Revision history for this message
Victor Martinez (victored) wrote :

Works fine.

review: Approve
Revision history for this message
Corentin Noël (tintou) wrote :

Let's go for it !

review: Approve
Revision history for this message
Danielle Foré (danrabbit) wrote :

I think we have to manually merge. I don't think rabbitbot will merge to another branch :p

Revision history for this message
Danielle Foré (danrabbit) wrote :

This is supposedly merged, but I don't see the revision where it was merged...

Revision history for this message
David Gomes (davidgomes) wrote :

>p:~audience-members/audience/gtk-3.12

Revision history for this message
Danielle Foré (danrabbit) wrote :

David, please notice that on that page there is no revision where this branch is merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Audience.vala'
2--- src/Audience.vala 2014-05-02 22:16:10 +0000
3+++ src/Audience.vala 2014-05-08 03:02:39 +0000
4@@ -109,6 +109,12 @@
5 mainbox.pack_start (clutter);
6 mainbox.pack_start (welcome);
7
8+ var header = new Gtk.HeaderBar ();
9+ header.set_show_close_button (true);
10+ header.get_style_context ().remove_class ("header-bar");
11+
12+ mainwindow.set_titlebar (header);
13+
14 mainwindow.events |= Gdk.EventMask.POINTER_MOTION_MASK;
15 mainwindow.events |= Gdk.EventMask.LEAVE_NOTIFY_MASK;
16 mainwindow.events |= Gdk.EventMask.BUTTON_PRESS_MASK;

Subscribers

People subscribed via source and target branches