Merge lp:~elementary-apps/appcenter/no-double-update into lp:~elementary-apps/appcenter/appcenter

[Danielle Foré]

Don't show update button for updated apps

Decide to show the update button when we're choosing the row header so that these two are always in sync

[lp:~elementary-apps/appcenter/no-double-update]

198. By Danielle Foré on 2016-06-15

only use visible

[Felipe Escoto (philip.scott)]

review: Approve

=== modified file 'src/Views/AppListView.vala'
--- src/Views/AppListView.vala	2016-04-24 21:16:21 +0000
+++ src/Views/AppListView.vala	2016-06-15 17:11:22 +0000
@@ -116,6 +116,7 @@
     [CCode (instance_pos = -1)]
     private void package_row_update_header (Widgets.PackageRow row, Widgets.PackageRow? before) {
         bool update_available = row.package.update_available;
+        row.action_stack.visible = row.package.update_available;
         if (before == null && update_available) {
             var updates_grid = get_updates_grid ();
             row.set_header (updates_grid);

=== modified file 'src/Widgets/PackageRow.vala'
--- src/Widgets/PackageRow.vala	2016-03-20 00:34:08 +0000
+++ src/Widgets/PackageRow.vala	2016-06-15 17:11:22 +0000
@@ -29,7 +29,7 @@
 
     public Gtk.Button update_button;
     public Gtk.Button cancel_button;
-    Gtk.Stack action_stack;
+    public Gtk.Stack action_stack;
     Gtk.Grid update_grid;
     Gtk.ProgressBar update_progressbar;
     Gtk.Label update_label;
@@ -66,11 +66,7 @@
             changed ();
         });
 
-        action_stack.no_show_all = !package.update_available;
-        action_stack.show_all ();
         package.notify["update-available"].connect (() => {
-            action_stack.no_show_all = !package.update_available;
-            action_stack.show_all ();
             changed ();
         });