Merge lp:~elbati/sale-wkfl/sale_delivery_term_ondelete_constraints into lp:~sale-core-editors/sale-wkfl/7.0

Proposed by Lorenzo Battistini
Status: Merged
Merged at revision: 11
Proposed branch: lp:~elbati/sale-wkfl/sale_delivery_term_ondelete_constraints
Merge into: lp:~sale-core-editors/sale-wkfl/7.0
Diff against target: 30 lines (+4/-2)
1 file modified
sale_delivery_term/sale.py (+4/-2)
To merge this branch: bzr merge lp:~elbati/sale-wkfl/sale_delivery_term_ondelete_constraints
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp code review, no test Approve
Review via email: mp+160117@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve (code review, no test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sale_delivery_term/sale.py'
2--- sale_delivery_term/sale.py 2013-03-15 09:21:42 +0000
3+++ sale_delivery_term/sale.py 2013-04-22 14:06:23 +0000
4@@ -49,7 +49,7 @@
5 _name = 'sale.delivery.term.line'
6 _rec_name = 'term_id'
7 _columns = {
8- 'term_id': fields.many2one('sale.delivery.term', 'Term'),
9+ 'term_id': fields.many2one('sale.delivery.term', 'Term', ondelete='cascade'),
10 'quantity_perc': fields.float('Quantity percentage', required=True, help="For 20% set '0.2'"),
11 'delay': fields.float('Delivery Lead Time', required=True,
12 help="Number of days between the order confirmation and the shipping of the products to the customer"),
13@@ -65,6 +65,7 @@
14 if res_dict['value'].has_key('type'):
15 del res_dict['value']['type']
16 if res_dict['value'].has_key('tax_id'):
17+ res_dict['value']['tax_ids'] = res_dict['value']['tax_id']
18 del res_dict['value']['tax_id']
19 return res_dict
20
21@@ -113,7 +114,8 @@
22 _name = 'sale.order.line.master'
23 _columns = {
24 'order_id': fields.many2one('sale.order', 'Order Reference', required=True, ondelete='cascade'),
25- 'delivery_term_id': fields.many2one('sale.delivery.term', 'Delivery term', required=True),
26+ 'delivery_term_id': fields.many2one('sale.delivery.term', 'Delivery term',
27+ required=True, ondelete='restrict'),
28 'name': fields.char('Description', size=256, required=True),
29 'product_id': fields.many2one('product.product', 'Product', domain=[('sale_ok', '=', True)]),
30 'price_unit': fields.float('Unit Price', required=True, digits_compute= dp.get_precision('Sale Price')),

Subscribers

People subscribed via source and target branches