Report - Printing and Sending

Merge lp:~elbati/report-print-send/fix_base_report_to_printer_authors into lp:~report-print-send-core-editors/report-print-send/6.1

  1. fix_base_report_to_printer_authors
  2. Merge into 6.1
Proposed by Lorenzo Battistini
Status: Merged
Merged at revision: 7
Proposed branch: lp:~elbati/report-print-send/fix_base_report_to_printer_authors
Merge into: lp:~report-print-send-core-editors/report-print-send/6.1
Diff against target: 12 lines (+1/-1)
1 file modified
base_report_to_printer/__openerp__.py (+1/-1)
To merge this branch: bzr merge lp:~elbati/report-print-send/fix_base_report_to_printer_authors
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Review via email: mp+143380@code.launchpad.net

Description of the change

we decided to use only the 'agile business group' name as modules' author

To post a comment you must log in.
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Did you tested the usage of the list in the 'author' key?

Because, by reading the code of the openerp server, it was not so evident to me that it is supported.

review: Needs Information
Revision history for this message
Lorenzo Battistini (elbati) wrote :

On 01/16/2013 09:12 AM, Guewen Baconnier @ Camptocamp wrote:
> Review: Needs Information
>
> Did you tested the usage of the list in the 'author' key?
>
> Because, by reading the code of the openerp server, it was not so evident to me that it is supported.

Just saw modules like 'base_crypt', but that doesn't seem to influence
apps site <http://v6apps.openerp.com/addon/648>.
It would be interesting to know how new version of apps site will work.

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Right, thanks for the pointer!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'base_report_to_printer/__openerp__.py'
2--- base_report_to_printer/__openerp__.py 2012-12-07 17:54:13 +0000
3+++ base_report_to_printer/__openerp__.py 2013-01-15 18:55:24 +0000
4@@ -52,7 +52,7 @@
5
6 After finishing the configuration, you will just have to click on printing button associated to the report (or launch the report by a wizard or whatever) and the system will automatically send the report to the previously set printer
7 """,
8- 'author': 'Agile Business Group & Domsense, Pegueroles SCP, NaN',
9+ 'author': ['Agile Business Group', 'Pegueroles SCP', 'NaN'],
10 'website': 'http://www.agilebg.com',
11 'license': 'AGPL-3',
12 "depends" : ['base', 'base_calendar'],

Subscribers

People subscribed via source and target branches