Merge lp:~elbati/enapps-csv-import-tool/fix_file_to_list_method into lp:~enapps-london-uk/enapps-csv-import-tool/old_trunk

[Lorenzo Battistini]

This fixes bug 999180
replacing the custom procedure used by 'file_to_list' method with python 'csv' reader

[Juan Rial (OpenERP) (jri-openerp)]

Lorenzo: good point, but I'd get rid of file_to_list altogether like in my previously proposed patch; if the method body fits on one line, there's no point in keeping the method around. Although one could also argue your version is more readable..

But anyway, Enapps doesn't accept merge proposals through launchpad. They use LP only to publish their work. Development happens on an internal git repo, and I'd guess the codebase on LP is probably outdated already.

You might want to check out my fully_patched branch of this project. That's one has all my patches, and is still updated whenever I find a new bug (although I'm using it less now, so not finding many bugs anymore). It can be found here: lp:~jri-openerp/enapps-csv-import-tool/fully-patched

[Lorenzo Battistini (elbati)]

On 09/05/2012 06:07 PM, Juan Rial (OpenERP) wrote:
> Lorenzo: good point, but I'd get rid of file_to_list altogether like in my previously proposed patch; if the method body fits on one line, there's no point in keeping the method around. Although one could also argue your version is more readable..
>
> But anyway, Enapps doesn't accept merge proposals through launchpad. They use LP only to publish their work. Development happens on an internal git repo, and I'd guess the codebase on LP is probably outdated already.
>
> You might want to check out my fully_patched branch of this project. That's one has all my patches, and is still updated whenever I find a new bug (although I'm using it less now, so not finding many bugs anymore). It can be found here: lp:~jri-openerp/enapps-csv-import-tool/fully-patched

Hello Juan.
If Enapps doesn't accept merge proposals, wouldn't it be better if we
create new project (with your fully-patched branch) where we can easily
collaborate and handle bugs, etc?

[Lorenzo Battistini (elbati)]

Fixed by http://bazaar.launchpad.net/~enapps-london-uk/enapps-csv-import-tool/trunk/revision/6/ea_import/ea_import_chain.py

review: Disapprove

Unmerged revisions

6. By Lorenzo Battistini on 2012-09-05

[FIX] ea_import
Using csv module instead of custom procedure

=== modified file 'ea_import/ea_import_chain.py'
--- ea_import/ea_import_chain.py	2012-05-28 12:49:58 +0000
+++ ea_import/ea_import_chain.py	2012-09-05 14:53:18 +0000
@@ -23,6 +23,7 @@
 import base64
 import datetime
 from cStringIO import StringIO
+import csv
 
 
 class ea_import_chain(osv.osv):
@@ -94,22 +95,7 @@
     def file_to_list(self, cr, uid, ids, context={}):
         result = []
         for chain in self.browse(cr, uid, ids, context={}):
-            input_file = StringIO(base64.b64decode(chain.input_file))
-            previouse_line = []
-            for string_record in input_file:
-                if not string_record.strip():
-                    break
-                next_line = string_record.decode(chain.charset).split(chain.separator)
-                if previouse_line:
-                    previouse_line[-1] += next_line[0]
-                    next_line = previouse_line + next_line[1:]
-                last_item = next_line[-1].strip()
-                if last_item and (last_item[0] == chain.delimiter or previouse_line) and last_item[-1] != chain.delimiter:
-                    previouse_line = next_line
-                    continue
-                previouse_line = []
-                delimiter = chain.delimiter and chain.delimiter + "\n\r" or "\n\r"
-                result.append(map(lambda a: a.strip(delimiter), next_line))
+            result.extend(list(csv.reader(StringIO(base64.b64decode(chain.input_file)), delimiter=str(chain.separator), quotechar=str(chain.delimiter))))
         return result