Merge lp:~elbati/account-invoicing/adding_account_invoice_force_number into lp:~account-core-editors/account-invoicing/6.1

[Lorenzo Battistini]

This module allows to force the invoice numbering.
    It displays the internal_number field. If user fills that field, the typed value will be used as invoice (and move) number. Otherwise, the next sequence number will be retrieved and saved.
    So, the new field has to be used when user doesn't want to use the default invoice numbering for a specific invoice

[lp:~elbati/account-invoicing/adding_account_invoice_force_number]

13. By Lorenzo Battistini on 2012-11-16

[FIX] header

[Stefan Rijnhart (Opener) (stefan-opener)]

Code looks good.

review: Approve (code reading)

[Niels Huylebroeck (red15)]

If this is for v7.0 you have to drop the <field name="type">form</field> line because it will complain about this. If meant for multiple versions it's ok to leave this in, as v7 will "only" complain about it (but v6 would error if it's not there)

Another small remark I have is that your xpath expression might be a bit too specific, the question is do we want it to work or do we want to get an error when the view is not 100% what we expected ?

I would suggest we avoid errors for the user and we try to work with as many views as possible (even if view might not look really good, the field would still be shown and no error) My suggestion for the xpath in question :"//field[@name='fiscal_position']" )

review: Approve

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Ok, he propose this to be merged in v6.1 so I merge it. We'll create soon the 7.0 series where you'll be able to correct that.

Thank for review !

Regards,

Joël

=== added directory 'account_invoice_force_number'
=== added file 'account_invoice_force_number/AUTHORS.txt'
--- account_invoice_force_number/AUTHORS.txt	1970-01-01 00:00:00 +0000
+++ account_invoice_force_number/AUTHORS.txt	2012-11-16 23:37:19 +0000
@@ -0,0 +1,1 @@
+Lorenzo Battistini <[e-mail]>

=== added file 'account_invoice_force_number/__init__.py'
--- account_invoice_force_number/__init__.py	1970-01-01 00:00:00 +0000
+++ account_invoice_force_number/__init__.py	2012-11-16 23:37:19 +0000
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#    
+#    Copyright (C) 2011 Agile Business Group sagl (<http://www.agilebg.com>)
+#    Copyright (C) 2011 Domsense srl (<http://www.domsense.com>)
+#    All Rights Reserved
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+import invoice

=== added file 'account_invoice_force_number/__openerp__.py'
--- account_invoice_force_number/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_invoice_force_number/__openerp__.py	2012-11-16 23:37:19 +0000
@@ -0,0 +1,40 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#    
+#    Copyright (C) 2011 Agile Business Group sagl (<http://www.agilebg.com>)
+#    Copyright (C) 2011 Domsense srl (<http://www.domsense.com>)
+#    All Rights Reserved
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{
+    'name': "Force Invoice Number",
+    'version': '0.1',
+    'category': 'Generic Modules/Accounting',
+    'description': """
+    This module allows to force the invoice numbering.
+    It displays the internal_number field. If user fills that field, the typed value will be used as invoice (and move) number. Otherwise, the next sequence number will be retrieved and saved.
+    So, the new field has to be used when user doesn't want to use the default invoice numbering for a specific invoice.
+    """,
+    'author': 'Agile Business Group & Domsense',
+    'website': 'http://www.agilebg.com',
+    'license': 'AGPL-3',
+    "depends" : ['account'],
+    "init_xml" : [],
+    "update_xml" : ['invoice_view.xml'],
+    "demo_xml" : [],
+    "active": False,
+    "installable": True
+}

=== added directory 'account_invoice_force_number/i18n'
=== added file 'account_invoice_force_number/i18n/account_invoice_force_number.pot'
--- account_invoice_force_number/i18n/account_invoice_force_number.pot	1970-01-01 00:00:00 +0000
+++ account_invoice_force_number/i18n/account_invoice_force_number.pot	2012-11-16 23:37:19 +0000
@@ -0,0 +1,41 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* account_invoice_force_number
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 6.0.3\n"
+"Report-Msgid-Bugs-To: [e-mail]\n"
+"POT-Creation-Date: 2011-11-16 16:44+0000\n"
+"PO-Revision-Date: 2011-11-16 16:44+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: account_invoice_force_number
+#: view:account.invoice:0
+msgid "Force Number"
+msgstr ""
+
+#. module: account_invoice_force_number
+#: model:ir.module.module,description:account_invoice_force_number.module_meta_information
+msgid "\n"
+"    This module allows to force the invoice numbering.\n"
+"    It displays the internal_number field. If user fills that field, the typed value will be used as invoice (and move) number. Otherwise, the next sequence sequence number will be retrieved and saved.\n"
+"    So, the new field has to be used when user doesn't want to use the default invoice numbering for a specific invoice.\n"
+"    "
+msgstr ""
+
+#. module: account_invoice_force_number
+#: model:ir.module.module,shortdesc:account_invoice_force_number.module_meta_information
+msgid "Force Invoice Number"
+msgstr ""
+
+#. module: account_invoice_force_number
+#: model:ir.model,name:account_invoice_force_number.model_account_invoice
+msgid "Invoice"
+msgstr ""
+

=== added file 'account_invoice_force_number/i18n/it.po'
--- account_invoice_force_number/i18n/it.po	1970-01-01 00:00:00 +0000
+++ account_invoice_force_number/i18n/it.po	2012-11-16 23:37:19 +0000
@@ -0,0 +1,47 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* account_invoice_force_number
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 6.0.3\n"
+"Report-Msgid-Bugs-To: [e-mail]\n"
+"POT-Creation-Date: 2011-11-17 15:20+0000\n"
+"PO-Revision-Date: 2011-11-17 16:29+0100\n"
+"Last-Translator: Lorenzo Battistini <[e-mail]>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: \n"
+
+#. module: account_invoice_force_number
+#: view:account.invoice:0
+msgid "Force Number"
+msgstr "Forza numero"
+
+#. module: account_invoice_force_number
+#: model:ir.module.module,description:account_invoice_force_number.module_meta_information
+msgid ""
+"\n"
+"    This module allows to force the invoice numbering.\n"
+"    It displays the internal_number field. If user fills that field, the typed value will be used as invoice (and move) number. Otherwise, the next sequence sequence number will be retrieved and saved.\n"
+"    So, the new field has to be used when user doesn't want to use the default invoice numbering for a specific invoice.\n"
+"    "
+msgstr ""
+"\n"
+"    This module allows to force the invoice numbering.\n"
+"    It displays the internal_number field. If user fills that field, the typed value will be used as invoice (and move) number. Otherwise, the next sequence sequence number will be retrieved and saved.\n"
+"    So, the new field has to be used when user doesn't want to use the default invoice numbering for a specific invoice.\n"
+"    "
+
+#. module: account_invoice_force_number
+#: model:ir.module.module,shortdesc:account_invoice_force_number.module_meta_information
+msgid "Force Invoice Number"
+msgstr "Forza numero fattura"
+
+#. module: account_invoice_force_number
+#: model:ir.model,name:account_invoice_force_number.model_account_invoice
+msgid "Invoice"
+msgstr "Fattura"
+

=== added file 'account_invoice_force_number/invoice.py'
--- account_invoice_force_number/invoice.py	1970-01-01 00:00:00 +0000
+++ account_invoice_force_number/invoice.py	2012-11-16 23:37:19 +0000
@@ -0,0 +1,30 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#    
+#    Copyright (C) 2011 Agile Business Group sagl (<http://www.agilebg.com>)
+#    Copyright (C) 2011 Domsense srl (<http://www.domsense.com>)
+#    All Rights Reserved
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from osv import fields, osv
+
+class account_invoice(osv.osv):
+    _inherit = "account.invoice"
+    _columns = {
+        'internal_number': fields.char('Invoice Number', size=32, readonly=True, states={'draft':[('readonly',False)]}),
+        }
+account_invoice()

=== added file 'account_invoice_force_number/invoice_view.xml'
--- account_invoice_force_number/invoice_view.xml	1970-01-01 00:00:00 +0000
+++ account_invoice_force_number/invoice_view.xml	2012-11-16 23:37:19 +0000
@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+<data>
+
+        <record model="ir.ui.view" id="account_invoice_form_int_number">
+            <field name="name">account.invoice.form.int_number</field>
+            <field name="model">account.invoice</field>
+            <field name="inherit_id" ref="account.invoice_form"/>
+            <field name="type">form</field>
+            <field name="arch" type="xml">
+                <xpath expr="/form/group/field[@name='fiscal_position']" position="after">
+                    <field name="internal_number" attrs="{'invisible':[('state','!=','draft')]}" string="Force Number" help="Force invoice number. Use this field if you don't want to use the default numbering"/>
+                </xpath>
+            </field>
+        </record>
+
+</data>
+</openerp>