Merge lp:~elachuni/wsgi-oops/dont-iterate-weakkeydicts into lp:wsgi-oops

[Anthony Lenton]

Using iterators from weakkeydicts is not threadsafe, (see Python bug http://bugs.python.org/issue839159).

This branch avoids using these iterators, to fix bug #574399.

Thanks MenTaLguY for spotting the fix!

[Elliot Murphy (statik)]

Nice fix!

review: Approve

=== modified file 'canonical/oops/serializer.py'
--- canonical/oops/serializer.py	2010-02-22 20:01:02 +0000
+++ canonical/oops/serializer.py	2010-05-06 19:39:26 +0000
@@ -164,7 +164,8 @@
                 # Key wasn't seen yet.  Use the maximum sequence from all
                 # known serializers.
                 sequence = max(serializer.get_initial_sequence() for
-                               serializer in self._serializers[self._key])
+                               serializer in
+                               self._serializers[self._key].keys())
             else:
                 # That's the most common path by far, so even though this
                 # all sounds complex, the overhead isn't significant.