Merge lp:~elachuni/ubuntu-webcatalog/screenshots-and-reviews into lp:ubuntu-webcatalog
Proposed by
Anthony Lenton
Status: | Merged |
---|---|
Approved by: | Łukasz Czyżykowski |
Approved revision: | 108 |
Merged at revision: | 107 |
Proposed branch: | lp:~elachuni/ubuntu-webcatalog/screenshots-and-reviews |
Merge into: | lp:ubuntu-webcatalog |
Diff against target: |
93 lines (+30/-6) 3 files modified
src/webcatalog/tests/test_views.py (+22/-2) src/webcatalog/utilities.py (+6/-3) src/webcatalog/views.py (+2/-1) |
To merge this branch: | bzr merge lp:~elachuni/ubuntu-webcatalog/screenshots-and-reviews |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Canonical Consumer Applications Hackers | Pending | ||
Review via email: mp+102616@code.launchpad.net |
Commit message
Fix screenshots and reviews.
Description of the change
A fix for two issues uncovered during testing:
- The review page crashes for packages with colons in their names. Afaik this is an issue only for multiarch packages (that's why they picked that separator). See for example http://
http://
- The screenshots page fails when there's more than one app for a given package name (this includes the same app on two different distroseries). See for example https:/
To post a comment you must log in.