Merge lp:~elachuni/ubuntu-webcatalog/latest-app into lp:ubuntu-webcatalog

[Anthony Lenton]

Made the default URL for apps always render the latest available version for an app, instead of redirecting to a user-agent guessed distroseries-specific version.

Overview
========
This branch makes the default URL for apps (the distroseries-agnostic one) always render the latest available version for an app, instead of redirecting to a user-agent guessed distroseries-specific version, and starts work towards making department views and search results distroseries-agnostic too.

Details
=======
The code for rendering the latest available version of an app instead of redirecting was fairly simple (as the AppicationManager object already had a find_best method), and removed more code than it added afaict.
The following items are work towards distroseries-agnostic department lists and search results:

- Added an 'is_latest' field on Application
- Added a 'check_all_latest' command, that batches updates to that the running time goes from zomg slow to a few seconds, on a 60K app DB.
- import_for_purchase_apps updates the is_latest bit after each run. (I wonder if this makes more sense than just running check_all_latest after importing for-purchase apps, as check_all_latest is now pretty fast. Maybe even check_latest could be removed).
- Added is_latest to the list_filters in Application's admin UI

While I was there I couldn't resist a couple of drive-throughs:

- Refactored the part of the application_detail view that sent an email into the EmailDownloadLinkForm (I wanted to get it out of the view and I think it makes sense on the form, I wouldn't mind moving it somewhere else instead)
- Refactored import_for_purchase_apps so that icon data is fetched once per app, instead of once per app per distroseries.

[lp:~elachuni/ubuntu-webcatalog/latest-app]

83. By Anthony Lenton on 2012-03-16

Refactored check_all_latest to remove sillyness.

[Łukasz Czyżykowski (lukasz-czyzykowski)]

review: Approve

=== modified file 'src/webcatalog/admin.py'
--- src/webcatalog/admin.py	2012-03-09 15:11:21 +0000
+++ src/webcatalog/admin.py	2012-03-16 04:28:18 +0000
@@ -40,7 +40,7 @@
 class ApplicationAdmin(admin.ModelAdmin):
     list_display = ('package_name', 'name', 'comment', 'distroseries')
     search_fields = ('package_name', 'name', 'comment')
-    list_filter = ('distroseries', 'departments')
+    list_filter = ('distroseries', 'for_purchase', 'is_latest', 'departments')
     exclude = ('for_purchase', 'archive_id')
 
 

=== modified file 'src/webcatalog/forms.py'
--- src/webcatalog/forms.py	2012-03-13 15:16:22 +0000
+++ src/webcatalog/forms.py	2012-03-16 04:28:18 +0000
@@ -27,6 +27,9 @@
 from StringIO import StringIO
 
 from django import forms
+from django.conf import settings
+from django.core.mail import EmailMultiAlternatives
+from django.template.loader import render_to_string
 
 from webcatalog.models import Application
 
@@ -116,3 +119,17 @@
 
 class EmailDownloadLinkForm(forms.Form):
     email = forms.EmailField()
+
+    def send_email(self, app_name, link):
+        subject = 'Link for {0}'.format(app_name)
+        context = {'name': app_name, 'link': link}
+        html = render_to_string('webcatalog/email_download_link.html',
+                                context)
+        text = render_to_string('webcatalog/email_download_link.txt',
+                                context)
+        sender = ("Ubuntu Application Directory <%s>" %
+                settings.NOREPLY_FROM_ADDRESS)
+        recipient = [self.cleaned_data['email']]
+        message = EmailMultiAlternatives(subject, text, sender, recipient)
+        message.attach_alternative(html, 'text/html')
+        message.send()

=== added file 'src/webcatalog/management/commands/check_all_latest.py'
--- src/webcatalog/management/commands/check_all_latest.py	1970-01-01 00:00:00 +0000
+++ src/webcatalog/management/commands/check_all_latest.py	2012-03-16 04:28:18 +0000
@@ -0,0 +1,64 @@
+#   -*- coding: utf-8 -*-
+#   This file is part of the Apps Directory
+#   Copyright (C) 2011 Canonical Ltd.
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+"""Management command to update the 'is_latest' bit on *all* Applications."""
+
+from __future__ import (
+    absolute_import,
+    )
+
+from django.core.management.base import BaseCommand
+
+from webcatalog.models import Application
+
+__metaclass__ = type
+__all__ = [
+    'Command',
+    ]
+
+BATCH_SIZE = 200
+
+
+class Command(BaseCommand):
+    help = "Updates the 'is_latest' bit on all Applications."
+
+    def handle(self, *args, **options):
+        """A naive implementation of this command could be:
+
+        for p in Application.objects.values_list('package_name',
+            flat=True).distinct(): Application.objects.check_latest(p)
+
+        This command should do exactly that, only much faster.
+        """
+        # 1. Clear all is_latest bits
+        Application.objects.all().update(is_latest=False)
+
+        # 2. Update is_latest in batches of BATCH_SIZE.
+        packages = Application.objects.values_list('id',
+            'package_name').order_by('package_name', '-distroseries__version')
+        current_package_name = None
+        to_update = []
+        for app_id, app_package_name in packages:
+            if current_package_name != app_package_name:
+                to_update.append(app_id)
+                if len(to_update) >= BATCH_SIZE:
+                    Application.objects.filter(id__in=to_update).update(
+                        is_latest=True)
+                    to_update = []
+                current_package_name = app_package_name
+        if to_update:
+            Application.objects.filter(id__in=to_update).update(is_latest=True)

=== modified file 'src/webcatalog/management/commands/import_for_purchase_apps.py'
--- src/webcatalog/management/commands/import_for_purchase_apps.py	2012-01-06 17:54:47 +0000
+++ src/webcatalog/management/commands/import_for_purchase_apps.py	2012-03-16 04:28:18 +0000
@@ -57,6 +57,8 @@
             raise Exception("Couldn't connect to server at %s" % url)
         app_list = json.loads(response.read())
         for app_data in app_list:
+            # get icon data once per app (not per app per distroseries!)
+            icon_data = self.get_icon_data(app_data)
             for series_name in app_data['series']:
                 distroseries, created = DistroSeries.objects.get_or_create(
                     code_name=series_name)
@@ -64,9 +66,10 @@
                     self.output(
                         "Created a DistroSeries record called '{0}'.\n".format(
                             series_name), 1)
-                self.import_app_from_data(app_data, distroseries)
+                self.import_app_from_data(app_data, icon_data, distroseries)
+            Application.objects.check_latest(app_data['package_name'])
 
-    def import_app_from_data(self, app_data, distroseries):
+    def import_app_from_data(self, app_data, icon_data, distroseries):
         form = ForPurchaseApplicationForm.from_json(app_data, distroseries)
         if form.is_valid():
             app = form.save(commit=False)
@@ -74,15 +77,20 @@
             app.for_purchase = True
             app.save()
             app.update_departments()
-            self.add_icon_to_app(app, data=app_data.get('icon_data', ''),
-                url=app_data.get('icon_url', ''))
+            self.add_icon_to_app(app, data=icon_data)
             self.output(u"{0} created.\n".format(app.name).encode('utf-8'), 1)
 
-    def add_icon_to_app(self, app, data, url):
-        if data:
-            pngfile = StringIO(data.decode('base64'))
+    def get_icon_data(self, app_data):
+        icon_data = app_data.get('icon_data', '')
+        if icon_data:
+            data = icon_data.decode('base64')
         else:
-            pngfile = urllib.urlopen(url)
+            url = app_data.get('icon_url', '')
+            data = urllib.urlopen(url).read()
+        return data
+
+    def add_icon_to_app(self, app, data):
+        pngfile = StringIO(data)
         try:
             fd, filename = mkstemp(prefix=app.package_name, suffix='.png')
             iconfile = os.fdopen(fd, 'w')

=== modified file 'src/webcatalog/managers.py'
--- src/webcatalog/managers.py	2012-03-08 18:00:09 +0000
+++ src/webcatalog/managers.py	2012-03-16 04:28:18 +0000
@@ -29,6 +29,7 @@
     ]
 
 from django.db import models
+from django.http import Http404
 
 
 class ApplicationManager(models.Manager):
@@ -36,3 +37,20 @@
         options = self.filter(**kwargs).order_by('-distroseries__version')
         if options.exists():
             return options[0]
+
+    def find_best_or_404(self, **kwargs):
+        app = self.find_best(**kwargs)
+        if app is None:
+            raise Http404()
+        return app
+
+    def check_latest(self, package_name):
+        """Check which app with the given package_name is the latest"""
+        options = self.filter(package_name=package_name).order_by(
+            '-distroseries__version')
+        is_latest = True
+        for option in options:
+            if option.is_latest != is_latest:
+                option.is_latest = is_latest
+                option.save()
+            is_latest = False

=== added file 'src/webcatalog/migrations/0013_add_is_latest.py'
--- src/webcatalog/migrations/0013_add_is_latest.py	1970-01-01 00:00:00 +0000
+++ src/webcatalog/migrations/0013_add_is_latest.py	2012-03-16 04:28:18 +0000
@@ -0,0 +1,162 @@
+# encoding: utf-8
+import datetime
+from south.db import db
+from south.v2 import SchemaMigration
+from django.db import models
+
+class Migration(SchemaMigration):
+
+    def forwards(self, orm):
+        
+        # Adding field 'Application.version'
+        db.add_column('webcatalog_application', 'version', self.gf('django.db.models.fields.CharField')(default='', max_length=32, blank=True), keep_default=False)
+
+        # Adding field 'Application.is_latest'
+        db.add_column('webcatalog_application', 'is_latest', self.gf('django.db.models.fields.BooleanField')(default=False), keep_default=False)
+
+
+    def backwards(self, orm):
+        
+        # Deleting field 'Application.version'
+        db.delete_column('webcatalog_application', 'version')
+
+        # Deleting field 'Application.is_latest'
+        db.delete_column('webcatalog_application', 'is_latest')
+
+
+    models = {
+        'auth.group': {
+            'Meta': {'object_name': 'Group'},
+            'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'name': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '80'}),
+            'permissions': ('django.db.models.fields.related.ManyToManyField', [], {'to': "orm['auth.Permission']", 'symmetrical': 'False', 'blank': 'True'})
+        },
+        'auth.permission': {
+            'Meta': {'ordering': "('content_type__app_label', 'content_type__model', 'codename')", 'unique_together': "(('content_type', 'codename'),)", 'object_name': 'Permission'},
+            'codename': ('django.db.models.fields.CharField', [], {'max_length': '100'}),
+            'content_type': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['contenttypes.ContentType']"}),
+            'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'name': ('django.db.models.fields.CharField', [], {'max_length': '50'})
+        },
+        'auth.user': {
+            'Meta': {'object_name': 'User'},
+            'date_joined': ('django.db.models.fields.DateTimeField', [], {'default': 'datetime.datetime.now'}),
+            'email': ('django.db.models.fields.EmailField', [], {'max_length': '75', 'blank': 'True'}),
+            'first_name': ('django.db.models.fields.CharField', [], {'max_length': '30', 'blank': 'True'}),
+            'groups': ('django.db.models.fields.related.ManyToManyField', [], {'to': "orm['auth.Group']", 'symmetrical': 'False', 'blank': 'True'}),
+            'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'is_active': ('django.db.models.fields.BooleanField', [], {'default': 'True'}),
+            'is_staff': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
+            'is_superuser': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
+            'last_login': ('django.db.models.fields.DateTimeField', [], {'default': 'datetime.datetime.now'}),
+            'last_name': ('django.db.models.fields.CharField', [], {'max_length': '30', 'blank': 'True'}),
+            'password': ('django.db.models.fields.CharField', [], {'max_length': '128'}),
+            'user_permissions': ('django.db.models.fields.related.ManyToManyField', [], {'to': "orm['auth.Permission']", 'symmetrical': 'False', 'blank': 'True'}),
+            'username': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '30'})
+        },
+        'contenttypes.contenttype': {
+            'Meta': {'ordering': "('name',)", 'unique_together': "(('app_label', 'model'),)", 'object_name': 'ContentType', 'db_table': "'django_content_type'"},
+            'app_label': ('django.db.models.fields.CharField', [], {'max_length': '100'}),
+            'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'model': ('django.db.models.fields.CharField', [], {'max_length': '100'}),
+            'name': ('django.db.models.fields.CharField', [], {'max_length': '100'})
+        },
+        'webcatalog.application': {
+            'Meta': {'unique_together': "(('distroseries', 'archive_id'),)", 'object_name': 'Application'},
+            'app_type': ('django.db.models.fields.CharField', [], {'max_length': '32', 'blank': 'True'}),
+            'architectures': ('django.db.models.fields.CharField', [], {'max_length': '255', 'blank': 'True'}),
+            'archive_id': ('django.db.models.fields.CharField', [], {'db_index': 'True', 'max_length': '64', 'null': 'True', 'blank': 'True'}),
+            'categories': ('django.db.models.fields.CharField', [], {'max_length': '255', 'blank': 'True'}),
+            'channel': ('django.db.models.fields.CharField', [], {'max_length': '255', 'blank': 'True'}),
+            'comment': ('django.db.models.fields.CharField', [], {'max_length': '255', 'blank': 'True'}),
+            'departments': ('django.db.models.fields.related.ManyToManyField', [], {'to': "orm['webcatalog.Department']", 'symmetrical': 'False', 'blank': 'True'}),
+            'description': ('django.db.models.fields.TextField', [], {'blank': 'True'}),
+            'distroseries': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['webcatalog.DistroSeries']"}),
+            'for_purchase': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
+            'icon': ('django.db.models.fields.files.ImageField', [], {'max_length': '200', 'null': 'True', 'blank': 'True'}),
+            'icon_name': ('django.db.models.fields.CharField', [], {'max_length': '255', 'blank': 'True'}),
+            'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'is_latest': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
+            'keywords': ('django.db.models.fields.CharField', [], {'max_length': '255', 'blank': 'True'}),
+            'mimetype': ('django.db.models.fields.CharField', [], {'max_length': '2048', 'blank': 'True'}),
+            'name': ('django.db.models.fields.CharField', [], {'max_length': '255'}),
+            'package_name': ('django.db.models.fields.CharField', [], {'max_length': '100'}),
+            'popcon': ('django.db.models.fields.IntegerField', [], {'null': 'True', 'blank': 'True'}),
+            'price': ('django.db.models.fields.DecimalField', [], {'null': 'True', 'max_digits': '7', 'decimal_places': '2', 'blank': 'True'}),
+            'ratings_average': ('django.db.models.fields.DecimalField', [], {'null': 'True', 'max_digits': '3', 'decimal_places': '2', 'blank': 'True'}),
+            'ratings_histogram': ('django.db.models.fields.CharField', [], {'max_length': '128', 'blank': 'True'}),
+            'ratings_total': ('django.db.models.fields.IntegerField', [], {'null': 'True', 'blank': 'True'}),
+            'screenshot_url': ('django.db.models.fields.URLField', [], {'max_length': '200', 'blank': 'True'}),
+            'section': ('django.db.models.fields.CharField', [], {'max_length': '32'}),
+            'version': ('django.db.models.fields.CharField', [], {'max_length': '32', 'blank': 'True'})
+        },
+        'webcatalog.consumer': {
+            'Meta': {'object_name': 'Consumer'},
+            'created_at': ('django.db.models.fields.DateTimeField', [], {'auto_now_add': 'True', 'blank': 'True'}),
+            'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'key': ('django.db.models.fields.CharField', [], {'max_length': '64'}),
+            'secret': ('django.db.models.fields.CharField', [], {'default': "'UAjOLIWzoDHCXiWfHxeeBYrsCQxFVx'", 'max_length': '255', 'blank': 'True'}),
+            'updated_at': ('django.db.models.fields.DateTimeField', [], {'auto_now': 'True', 'blank': 'True'}),
+            'user': ('django.db.models.fields.related.OneToOneField', [], {'related_name': "'oauth_consumer'", 'unique': 'True', 'to': "orm['auth.User']"})
+        },
+        'webcatalog.department': {
+            'Meta': {'object_name': 'Department'},
+            'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'name': ('django.db.models.fields.CharField', [], {'max_length': '64'}),
+            'parent': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['webcatalog.Department']", 'null': 'True', 'blank': 'True'}),
+            'slug': ('django.db.models.fields.SlugField', [], {'unique': 'True', 'max_length': '50', 'db_index': 'True'})
+        },
+        'webcatalog.distroseries': {
+            'Meta': {'object_name': 'DistroSeries'},
+            'code_name': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '20', 'db_index': 'True'}),
+            'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'version': ('django.db.models.fields.CharField', [], {'max_length': '10', 'blank': 'True'})
+        },
+        'webcatalog.exhibit': {
+            'Meta': {'object_name': 'Exhibit'},
+            'banner_url': ('django.db.models.fields.CharField', [], {'max_length': '1024'}),
+            'date_created': ('django.db.models.fields.DateTimeField', [], {'auto_now_add': 'True', 'blank': 'True'}),
+            'display': ('django.db.models.fields.NullBooleanField', [], {'null': 'True', 'blank': 'True'}),
+            'distroseries': ('django.db.models.fields.related.ManyToManyField', [], {'to': "orm['webcatalog.DistroSeries']", 'symmetrical': 'False'}),
+            'html': ('django.db.models.fields.TextField', [], {}),
+            'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'package_names': ('django.db.models.fields.CharField', [], {'max_length': '1024'}),
+            'published': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
+            'sca_id': ('django.db.models.fields.IntegerField', [], {})
+        },
+        'webcatalog.machine': {
+            'Meta': {'unique_together': "(('owner', 'uuid'),)", 'object_name': 'Machine'},
+            'hostname': ('django.db.models.fields.CharField', [], {'max_length': '64'}),
+            'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'logo_checksum': ('django.db.models.fields.CharField', [], {'max_length': '56', 'blank': 'True'}),
+            'owner': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['auth.User']"}),
+            'package_list': ('django.db.models.fields.TextField', [], {}),
+            'packages_checksum': ('django.db.models.fields.CharField', [], {'max_length': '56'}),
+            'uuid': ('django.db.models.fields.CharField', [], {'max_length': '32', 'db_index': 'True'})
+        },
+        'webcatalog.nonce': {
+            'Meta': {'object_name': 'Nonce'},
+            'consumer': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['webcatalog.Consumer']"}),
+            'created_at': ('django.db.models.fields.DateTimeField', [], {'auto_now_add': 'True', 'blank': 'True'}),
+            'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'nonce': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '255'}),
+            'token': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['webcatalog.Token']"})
+        },
+        'webcatalog.reviewstatsimport': {
+            'Meta': {'object_name': 'ReviewStatsImport'},
+            'distroseries': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['webcatalog.DistroSeries']", 'unique': 'True'}),
+            'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
+            'last_import': ('django.db.models.fields.DateTimeField', [], {'default': 'datetime.datetime.utcnow'})
+        },
+        'webcatalog.token': {
+            'Meta': {'object_name': 'Token'},
+            'consumer': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['webcatalog.Consumer']"}),
+            'created_at': ('django.db.models.fields.DateTimeField', [], {'auto_now_add': 'True', 'blank': 'True'}),
+            'name': ('django.db.models.fields.CharField', [], {'max_length': '255', 'blank': 'True'}),
+            'token': ('django.db.models.fields.CharField', [], {'default': "'hAZAjuVIwJwrqUVxBCgObaNCbFPGNcijNfArcynJqXKUAOhQkv'", 'max_length': '50', 'primary_key': 'True'}),
+            'token_secret': ('django.db.models.fields.CharField', [], {'default': "'wDrSVtSgATKkTXkRuufxIrtZEgllyWkLREKktgdfBtDDEoHgKs'", 'max_length': '50'}),
+            'updated_at': ('django.db.models.fields.DateTimeField', [], {'auto_now': 'True', 'blank': 'True'})
+        }
+    }
+
+    complete_apps = ['webcatalog']

=== modified file 'src/webcatalog/models/applications.py'
--- src/webcatalog/models/applications.py	2012-03-15 13:08:02 +0000
+++ src/webcatalog/models/applications.py	2012-03-16 04:28:18 +0000
@@ -23,7 +23,6 @@
     )
 
 import logging
-import re
 from datetime import datetime
 
 from django.contrib.auth.models import User
@@ -95,6 +94,7 @@
     ratings_average = models.DecimalField(max_digits=3, decimal_places=2,
         null=True, blank=True)
     ratings_histogram = models.CharField(max_length=128, blank=True)
+    is_latest = models.BooleanField()
 
     # Other desktop fields used by s-c
     # x-gnome-fullname

=== modified file 'src/webcatalog/tests/factory.py'
--- src/webcatalog/tests/factory.py	2012-03-15 13:08:02 +0000
+++ src/webcatalog/tests/factory.py	2012-03-16 04:28:18 +0000
@@ -94,7 +94,7 @@
         comment=None, description=None, icon_name='', icon=None,
         distroseries=None, arch='i686', ratings_average=None,
         ratings_total=None, ratings_histogram='', screenshot_url=None,
-        archive_id=None, version=''):
+        archive_id=None, version='', is_latest=False):
         if name is None:
             name = self.get_unique_string(prefix='Readable Name')
         if package_name is None:
@@ -112,7 +112,7 @@
             icon_name=icon_name, distroseries=distroseries, architectures=arch,
             ratings_average=ratings_average, ratings_total=ratings_total,
             ratings_histogram=ratings_histogram, screenshot_url=screenshot_url,
-            archive_id=archive_id, version=version)
+            archive_id=archive_id, version=version, is_latest=is_latest)
 
     def make_department(self, name, parent=None, slug=None):
         if slug is None:

=== modified file 'src/webcatalog/tests/test_commands.py'
--- src/webcatalog/tests/test_commands.py	2012-03-13 14:09:29 +0000
+++ src/webcatalog/tests/test_commands.py	2012-03-16 04:28:18 +0000
@@ -62,6 +62,7 @@
     'ImportExhibitsTestCase',
     'ImportForPurchaseAppsTestCase',
     'ImportRatingsTestCase',
+    'CheckAllLatestTestCase',
     ]
 
 
@@ -406,7 +407,10 @@
         super(ImportForPurchaseAppsTestCase, self).setUp()
         curdir = os.path.dirname(__file__)
         sca_apps_file = os.path.join(curdir, 'test_data', 'sca_apps.txt')
-        self.distroseries = DistroSeries.objects.create(code_name='natty')
+        self.natty = self.factory.make_distroseries(
+            code_name='natty', version='11.04')
+        self.maverick = self.factory.make_distroseries(
+            code_name='maverick', version='10.10')
         with open(sca_apps_file) as content:
             self.response_content = content.read()
         mock_response = Mock()
@@ -425,7 +429,7 @@
         call_command('import_for_purchase_apps')
 
         app_for_purchase = Application.objects.get(name='MyApp',
-            distroseries=self.distroseries)
+            distroseries=self.natty)
         self.assertEqual(True, app_for_purchase.for_purchase)
         self.assertTrue(app_for_purchase.description.find('hello') > -1)
 
@@ -433,23 +437,22 @@
         call_command('import_for_purchase_apps')
 
         app = Application.objects.get(name='MyApp',
-            distroseries=self.distroseries)
+            distroseries=self.natty)
         self.assertEqual(2, len(app.available_distroseries()))
 
     def test_app_gets_price(self):
         call_command('import_for_purchase_apps')
 
         app = Application.objects.get(name='MyApp',
-            distroseries=self.distroseries)
+            distroseries=self.natty)
         self.assertEqual(Decimal('2.50'), app.price)
 
     def test_existing_app_gets_updated_by_archive_id(self):
         self.factory.make_application(archive_id='launchpad_zematynnad2/myppa',
-            package_name='somethingelse',
-            distroseries=self.factory.make_distroseries(code_name='maverick'))
+            package_name='somethingelse', distroseries=self.maverick)
         self.factory.make_application(archive_id='launchpad_zematynnad2/myppa',
             package_name='somethingelse',
-            distroseries=self.distroseries)
+            distroseries=self.natty)
         self.assertEqual(2, Application.objects.count())
 
         call_command('import_for_purchase_apps')
@@ -463,16 +466,23 @@
         call_command('import_for_purchase_apps')
 
         app = Application.objects.get(name='MyApp',
-            distroseries=self.distroseries)
+            distroseries=self.natty)
         self.assertEqual(6461, app.icon.size)
 
     def test_app_gets_version(self):
         call_command('import_for_purchase_apps')
 
         app = Application.objects.get(package_name='hello',
-            distroseries=self.distroseries)
+            distroseries=self.natty)
         self.assertEqual('1.2.3', app.version)
 
+    def test_checks_latest(self):
+        call_command('import_for_purchase_apps')
+
+        app = Application.objects.get(package_name='hello',
+            distroseries=self.natty)
+        self.assertTrue(app.is_latest)
+
 
 class ImportRatingsTestCase(TestCaseWithFactory):
 
@@ -661,3 +671,24 @@
 
         retrieved = Exhibit.objects.get()
         self.assertEqual(expected, retrieved.html)
+
+
+class CheckAllLatestTestCase(TestCaseWithFactory):
+    def test_updates_all(self):
+        natty = self.factory.make_distroseries(code_name='natty',
+            version='11.04')
+        oneiric = self.factory.make_distroseries(code_name='oneiric',
+            version='11.10')
+        self.factory.make_application(package_name='foo', distroseries=natty)
+        self.factory.make_application(package_name='foo', distroseries=oneiric)
+        self.factory.make_application(package_name='bar', distroseries=natty,
+            is_latest=True)
+        self.factory.make_application(package_name='baz', distroseries=oneiric)
+
+        call_command('check_all_latest')
+
+        retrieved = Application.objects.filter(package_name='foo').order_by(
+            '-distroseries__code_name')
+        self.assertEqual([True, False], [app.is_latest for app in retrieved])
+        self.assertTrue(Application.objects.get(package_name='bar').is_latest)
+        self.assertTrue(Application.objects.get(package_name='baz').is_latest)

=== modified file 'src/webcatalog/tests/test_managers.py'
--- src/webcatalog/tests/test_managers.py	2012-03-08 18:00:09 +0000
+++ src/webcatalog/tests/test_managers.py	2012-03-16 04:28:18 +0000
@@ -48,3 +48,16 @@
             package_name=expected.package_name)
 
         self.assertEqual(expected.id, retrieved.id)
+
+    def test_check_latest(self):
+        for code_name in ['lucid', 'maverick', 'natty', 'oneiric']:
+            dseries = self.factory.make_distroseries(code_name=code_name)
+            self.factory.make_application(package_name='foobar',
+                distroseries=dseries)
+
+        Application.objects.check_latest('foobar')
+
+        retrieved = Application.objects.filter(package_name='foobar').order_by(
+            '-distroseries__code_name')
+        self.assertEqual([True, False, False, False], [app.is_latest
+            for app in retrieved])

=== modified file 'src/webcatalog/tests/test_models.py'
--- src/webcatalog/tests/test_models.py	2012-03-12 15:30:15 +0000
+++ src/webcatalog/tests/test_models.py	2012-03-16 04:28:18 +0000
@@ -25,7 +25,6 @@
 from django.core.urlresolvers import reverse
 
 from webcatalog.tests.factory import TestCaseWithFactory
-from webcatalog.models import Department
 
 __metaclass__ = type
 __all__ = [

=== modified file 'src/webcatalog/tests/test_views.py'
--- src/webcatalog/tests/test_views.py	2012-03-15 13:08:02 +0000
+++ src/webcatalog/tests/test_views.py	2012-03-16 04:28:18 +0000
@@ -309,46 +309,23 @@
 
 
 class ApplicationDetailNoSeriesTestCase(TestCaseWithFactory):
-
-    def test_defaults_to_specified_series(self):
-        # If a distroseries is not included in the url,
-        # and we cannot determine it from the user agent,
-        # we redirect to the one specified in the configuration.
-        natty = self.factory.make_distroseries(code_name='natty')
-        lucid = self.factory.make_distroseries(code_name='lucid')
-        natty_app = self.factory.make_application(
-            package_name='pkgfoo', distroseries=natty)
-        lucid_app = self.factory.make_application(
-            package_name='pkgfoo', distroseries=lucid)
-
-        for default_distro in ('natty', 'lucid'):
-            with patch_settings(DEFAULT_DISTRO=default_distro):
-                url = reverse('wc-package-detail', args=['pkgfoo'])
-                response = self.client.get(url)
-
-                self.assertRedirects(
-                    response, reverse(
-                        'wc-package-detail', args=[default_distro, 'pkgfoo']))
-
-    def test_redirects_to_ua_distroseries(self):
-        # If a distroseries is not included in the url, but we
-        # know it from the user agent, and the app exists for that
-        # distro series also, we redirect there.
-        natty = self.factory.make_distroseries(code_name='natty')
-        lucid = self.factory.make_distroseries(code_name='lucid')
-        natty_app = self.factory.make_application(
-            package_name='pkgfoo', distroseries=natty)
-        lucid_app = self.factory.make_application(
-            package_name='pkgfoo', distroseries=lucid)
+    def test_renders_latest(self):
+        # If a distroseries is not included in the url, we always render the
+        # latest available app
+        natty = self.factory.make_distroseries(code_name='natty',
+            version='11.04')
+        lucid = self.factory.make_distroseries(code_name='lucid',
+            version='10.04')
+        for dseries in [natty, lucid]:
+            self.factory.make_application(package_name='pkgfoo',
+                distroseries=dseries)
 
         url = reverse('wc-package-detail', args=['pkgfoo'])
-        with patch_settings(DEFAULT_DISTRO='natty'):
-            response = self.client.get(
-                url, HTTP_USER_AGENT='blah X11; Linux Ubuntu/10.04 blah blah')
+        response = self.client.get(url)
 
-        self.assertRedirects(
-            response, reverse(
-                'wc-package-detail', args=['lucid', 'pkgfoo']))
+        self.assertEqual(200, response.status_code)
+        used = response.context[0]['application']
+        self.assertEqual(natty, used.distroseries)
 
 
 class SearchTestCase(TestCaseWithFactory):

=== modified file 'src/webcatalog/views.py'
--- src/webcatalog/views.py	2012-03-12 15:30:15 +0000
+++ src/webcatalog/views.py	2012-03-16 04:28:18 +0000
@@ -30,7 +30,6 @@
 from convoy.combo import combine_files, parse_qs
 from django.conf import settings
 from django.contrib import messages
-from django.core.mail import EmailMultiAlternatives
 from django.core.paginator import Paginator
 from django.core.urlresolvers import reverse
 from django.db.models import Q
@@ -43,7 +42,6 @@
     render_to_response,
     )
 from django.template import RequestContext
-from django.template.loader import render_to_string
 from django.utils.translation import ugettext as _
 
 from webcatalog.forms import EmailDownloadLinkForm
@@ -179,47 +177,22 @@
 
 
 def application_detail(request, package_name, distro=None):
-
+    if distro is None:
+        app = Application.objects.find_best_or_404(package_name=package_name)
+    else:
+        app = get_object_or_404(Application, package_name=package_name,
+                                distroseries__code_name=distro)
     if request.POST:
         form = EmailDownloadLinkForm(request.POST)
-        app = get_object_or_404(Application, package_name=package_name,
-                                distroseries__code_name=distro)
         if form.is_valid():
-            subject = 'Link for {0}'.format(app.name)
-            link = request.build_absolute_uri(reverse('wc-package-detail',
-                            args=[distro, package_name]))
-            context = {'name': app.name, 'link': link}
-            html = render_to_string('webcatalog/email_download_link.html',
-                                    context)
-            text = render_to_string('webcatalog/email_download_link.txt',
-                                    context)
-            sender = ("Ubuntu Application Directory <%s>" %
-                    settings.NOREPLY_FROM_ADDRESS)
-            recipient = [form.cleaned_data['email']]
-            message = EmailMultiAlternatives(subject, text, sender, recipient)
-            message.attach_alternative(html, 'text/html')
-            message.send()
-
+            link = request.build_absolute_uri()
+            form.send_email(app.name, link)
             messages.success(request, _('Success. Your download link has been'
                                         ' sent.'))
             return HttpResponseRedirect(link)
     else:
         form = EmailDownloadLinkForm()
 
-    if distro is None:
-        useragent = UserAgentString(request.META.get('HTTP_USER_AGENT', ''))
-        # Check for the distroseries in the useragent, if we have it,
-        # redirect there.
-        if useragent.distroseries:
-            distro = useragent.distroseries
-        else:
-            distro = settings.DEFAULT_DISTRO
-        return HttpResponseRedirect(
-            reverse('wc-package-detail',
-                    args=[distro, package_name]))
-
-    app = get_object_or_404(Application, package_name=package_name,
-                            distroseries__code_name=distro)
     atts = {'application': app,
         'available_distroseries': app.available_distroseries(),
         'breadcrumbs': app.crumbs(),