Merge lp:~elachuni/ubuntu-webcatalog/blank-apps into lp:ubuntu-webcatalog

Proposed by Anthony Lenton
Status: Rejected
Rejected by: Natalia Bidart
Proposed branch: lp:~elachuni/ubuntu-webcatalog/blank-apps
Merge into: lp:ubuntu-webcatalog
Diff against target: 12 lines (+1/-1)
1 file modified
src/webcatalog/models/applications.py (+1/-1)
To merge this branch: bzr merge lp:~elachuni/ubuntu-webcatalog/blank-apps
Reviewer Review Type Date Requested Status
Michael Nelson (community) Approve
Review via email: mp+154810@code.launchpad.net

Description of the change

A trivial branch to add a blank=True argument to ApplicationWidget's applications field. This allows you to edit widgets from the admin UI, create them without apps before a bundle starts, add / remove widgets from the admin UI and clear all apps when when they're no longer needed.

To post a comment you must log in.
Revision history for this message
Michael Nelson (michael.nelson) wrote :

+1 - I'm assuming the change doesn't cause south to expect a migration due to a differing field def.

review: Approve
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Setting MP as Rejected to reduce numbers of landing candidates in @reviewlist.
Change status again if this MP is still current.

Unmerged revisions

179. By Anthony Lenton

Fixed admin UI form so that widgets can be created without linked apps.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/webcatalog/models/applications.py'
2--- src/webcatalog/models/applications.py 2012-09-06 14:07:55 +0000
3+++ src/webcatalog/models/applications.py 2013-03-21 21:14:05 +0000
4@@ -318,7 +318,7 @@
5 class ApplicationWidget(models.Model):
6 name = models.CharField(max_length=32,
7 help_text="Just a reference for the admin view.")
8- applications = models.ManyToManyField(Application)
9+ applications = models.ManyToManyField(Application, blank=True)
10 template_snippet = models.TextField()
11
12 def __unicode__(self):

Subscribers

People subscribed via source and target branches