Code review comment for lp:~elachuni/piston-mini-client/timeouts
Revision history for this message
| Jonathan Lange (jml) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Thanks for looking into this Anthony.
A few thoughts,
* Does the timeout span the whole request & response, or just the time it takes to get a connected socket? If the former, then a timeout per request would be very helpful.
* Have you had a chance to test this with a pathological endpoint as described in bug 937865? I don't know off the top of my head how to make such a thing, but would be happy to figure it out together with you. I don't think such a thing needs to be added to the automatic test suite, but it would be good to have at least once-off verification that the patch achieves its purpose.
* It would be helpful if the timeout exception included the time taken and a pointer to some docs on how to change the timeout.
Thanks again,
jml