Merge lp:~eh-dem/partner-contact-management/remove_is_company into lp:~partner-contact-core-editors/partner-contact-management/7.0

Status: Rejected
Rejected by: Sandy Carter (http://www.savoirfairelinux.com)
Proposed branch: lp:~eh-dem/partner-contact-management/remove_is_company
Merge into: lp:~partner-contact-core-editors/partner-contact-management/7.0
Diff against target: 15 lines (+0/-5)
1 file modified
partner_firstname/partner_view.xml (+0/-5)
To merge this branch: bzr merge lp:~eh-dem/partner-contact-management/remove_is_company
Reviewer Review Type Date Requested Status
Olivier Laurent (Acsone) (community) Disapprove
Partner and Contact Core Editors Pending
Review via email: mp+202543@code.launchpad.net

Description of the change

remove is_company from contact view added in https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_view_resubmit/+merge/195092.
In partner view, we create a company; from the company, we create a contact and again you add is_company field; it is redundant and the view doesn't display well

To post a comment you must log in.
Revision history for this message
Olivier Laurent (Acsone) (olivier-laurent) wrote :

1/ It is not redundant, it is a new feature allowing a company to be a child of another one.
2/ The "quality" of the inner form design is solved by https://code.launchpad.net/~nemry/partner-contact-management/7.0-partner-firstname/+merge/202713

review: Disapprove

Unmerged revisions

32. By El Hadji Dem (http://www.savoirfairelinux.com)

[IMP] remove is_company from contact view added in MP 195092

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'partner_firstname/partner_view.xml'
2--- partner_firstname/partner_view.xml 2013-11-13 16:18:13 +0000
3+++ partner_firstname/partner_view.xml 2014-01-21 20:12:25 +0000
4@@ -38,11 +38,6 @@
5 <field name="firstname"/>
6 </group>
7 </xpath>
8- <xpath expr="//form[@string='Contact']/sheet/div/h1" position="after">
9- <field name="is_company" on_change="onchange_type(is_company)" class="oe_inline"/>
10- <label for="is_company" string="Is a Company?"/>)
11- </xpath>
12-
13
14 </field>
15 </record>