We all may have different expectations regarding what should be the effect of a tag in an xml file. I'd say that what Eitan wanted to implement was a way to skip a few test suites by default unless explicitly whitelisted and that's, I believe, what the code does.
If the test suite was to be skipped under all circumstances, then it wouldn't be possible to run it without editing the xml file and I guess that's another thing that Eitan was trying to avoid.
Maybe the 'skip' name is misleading and a different one should be implemented such as 'skip_by_default'.
Anyway, my interpretation of the change might not be correct.
We all may have different expectations regarding what should be the effect of a tag in an xml file. I'd say that what Eitan wanted to implement was a way to skip a few test suites by default unless explicitly whitelisted and that's, I believe, what the code does.
If the test suite was to be skipped under all circumstances, then it wouldn't be possible to run it without editing the xml file and I guess that's another thing that Eitan was trying to avoid.
Maybe the 'skip' name is misleading and a different one should be implemented such as 'skip_by_default'.
Anyway, my interpretation of the change might not be correct.