Launchpad itself

Merge lp:~edwin-grubbs/launchpad/disable-summaries-for-distroseries into lp:launchpad/db-devel

  1. disable-summaries-for-distroseries
  2. Merge into db-devel
Proposed by Edwin Grubbs
Status: Merged
Approved by: Edwin Grubbs
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~edwin-grubbs/launchpad/disable-summaries-for-distroseries
Merge into: lp:launchpad/db-devel
Diff against target: 15 lines
1 file modified
lib/lp/registry/templates/productseries-milestone-table-row.pt (+4/-1)
To merge this branch: bzr merge lp:~edwin-grubbs/launchpad/disable-summaries-for-distroseries
Reviewer Review Type Date Requested Status
Francis J. Lacoste (community) release-critical Approve
Curtis Hovey (community) code Approve
Review via email: mp+14374@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Disabled the summary of bug counts and blueprint counts for milestones on the distroseries +index page.

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Here is the diff.

=== modified file 'lib/lp/registry/templates/productseries-milestone-table-row.pt'
--- lib/lp/registry/templates/productseries-milestone-table-row.pt 2009-10-20 22:13:22 +0000
+++ lib/lp/registry/templates/productseries-milestone-table-row.pt 2009-11-03 17:59:06 +0000
@@ -68,7 +68,10 @@
         </tal:not-yet>
       </tal:no-release>
     </td>
- <td>
+ <td tal:condition="view/is_distroseries_milestone">
+ <em>Not displayed on distroseries page for performance reasons.</em>
+ </td>
+ <td tal:condition="not: view/is_distroseries_milestone">
       <tal:summary
         content="structure milestone/summary/fmt:shorten/80" />
       <tal:bug-blueprint-details

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

New full diff:

=== modified file 'lib/lp/registry/templates/productseries-milestone-table-row.pt'
--- lib/lp/registry/templates/productseries-milestone-table-row.pt 2009-11-03 18:00:40 +0000
+++ lib/lp/registry/templates/productseries-milestone-table-row.pt 2009-11-03 19:01:17 +0000
@@ -68,9 +68,9 @@
         </tal:not-yet>
       </tal:no-release>
     </td>
- <td tal:condition="view/is_distroseries_milestone">
- <em>Not displayed on distroseries page for performance reasons.</em>
- </td>
+ <td tal:condition="view/is_distroseries_milestone"
+ tal:content="structure milestone/summary/fmt:shorten/80"
+ />
     <td tal:condition="not: view/is_distroseries_milestone">
       <tal:summary
         content="structure milestone/summary/fmt:shorten/80" />

Revision history for this message
Curtis Hovey (sinzui) wrote :

This looks good to land.

review: Approve (code)
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Real full diff. The last one was the incremental diff.

=== modified file 'lib/lp/registry/templates/productseries-milestone-table-row.pt'
--- lib/lp/registry/templates/productseries-milestone-table-row.pt 2009-10-20 22:13:22 +0000
+++ lib/lp/registry/templates/productseries-milestone-table-row.pt 2009-11-03 19:01:17 +0000
@@ -68,7 +68,10 @@
         </tal:not-yet>
       </tal:no-release>
     </td>
- <td>
+ <td tal:condition="view/is_distroseries_milestone"
+ tal:content="structure milestone/summary/fmt:shorten/80"
+ />
+ <td tal:condition="not: view/is_distroseries_milestone">
       <tal:summary
         content="structure milestone/summary/fmt:shorten/80" />
       <tal:bug-blueprint-details

Revision history for this message
Francis J. Lacoste (flacoste) :
review: Approve (release-critical)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/templates/productseries-milestone-table-row.pt'
2--- lib/lp/registry/templates/productseries-milestone-table-row.pt 2009-10-20 22:13:22 +0000
3+++ lib/lp/registry/templates/productseries-milestone-table-row.pt 2009-11-03 19:08:16 +0000
4@@ -68,7 +68,10 @@
5 </tal:not-yet>
6 </tal:no-release>
7 </td>
8- <td>
9+ <td tal:condition="view/is_distroseries_milestone"
10+ tal:content="structure milestone/summary/fmt:shorten/80"
11+ />
12+ <td tal:condition="not: view/is_distroseries_milestone">
13 <tal:summary
14 content="structure milestone/summary/fmt:shorten/80" />
15 <tal:bug-blueprint-details

Subscribers

People subscribed via source and target branches

to status/vote changes: