Merge lp:~edwin-grubbs/launchpad/bug-576388-proposing-team-info-message into lp:launchpad
Proposed by
Edwin Grubbs
Status: | Merged |
---|---|
Approved by: | Edwin Grubbs |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11103 |
Proposed branch: | lp:~edwin-grubbs/launchpad/bug-576388-proposing-team-info-message |
Merge into: | lp:launchpad |
Diff against target: |
86 lines (+35/-13) 2 files modified
lib/lp/registry/browser/person.py (+33/-11) lib/lp/registry/stories/team/xx-team-add-my-teams.txt (+2/-2) |
To merge this branch: | bzr merge lp:~edwin-grubbs/launchpad/bug-576388-proposing-team-info-message |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+29026@code.launchpad.net |
Description of the change
Improved informational message so that it will not say a team was proposed when it was really added due to having an existing invite.
To post a comment you must log in.
The branch looks good Edwin.
Personally I think:
team_string = team_names[0]
is more readable than:
[team_string] = team_names