Launchpad itself

Merge lp:~edwin-grubbs/launchpad/bug-562486-pending-gpg-keys into lp:launchpad

  1. bug-562486-pending-gpg-keys
  2. Merge into devel
Proposed by Edwin Grubbs on 2010-05-12
Status: Merged
Approved by: Curtis Hovey on 2010-05-12
Approved revision: no longer in the source branch.
Merged at revision: 10852
Proposed branch: lp:~edwin-grubbs/launchpad/bug-562486-pending-gpg-keys
Merge into: lp:launchpad
Diff against target: 39 lines (+4/-7)
2 files modified
lib/lp/registry/interfaces/person.py (+4/-5)
lib/lp/registry/stories/webservice/xx-person.txt (+0/-2)
To merge this branch: bzr merge lp:~edwin-grubbs/launchpad/bug-562486-pending-gpg-keys
Reviewer Review Type Date Requested Status
Curtis Hovey (community) 2010-05-12 Approve on 2010-05-12
Review via email: mp+25154@code.launchpad.net

Description of the Change

Summary
-------

Unexported IPerson.pending_gpg_keys, since it is not really useful,
and it was causing some strange errors.

Tests
-----

./bin/test -vv -t 'webservice/xx-person.txt|gpg-views.txt'

To post a comment you must log in.
Curtis Hovey (sinzui) wrote :

Thanks for the lovely fix.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/interfaces/person.py'
2--- lib/lp/registry/interfaces/person.py 2010-04-29 23:06:26 +0000
3+++ lib/lp/registry/interfaces/person.py 2010-05-12 14:15:42 +0000
4@@ -611,11 +611,10 @@
5 title=_("List of valid OpenPGP keys ordered by ID"),
6 readonly=False, required=False,
7 value_type=Reference(schema=IGPGKey)))
8- pending_gpg_keys = exported(
9- CollectionField(
10- title=_("Set of fingerprints pending confirmation"),
11- readonly=False, required=False,
12- value_type=Reference(schema=IGPGKey)))
13+ pending_gpg_keys = CollectionField(
14+ title=_("Set of fingerprints pending confirmation"),
15+ readonly=False, required=False,
16+ value_type=Reference(schema=IGPGKey))
17 inactive_gpg_keys = Attribute(
18 "List of inactive OpenPGP keys in LP Context, ordered by ID")
19 wiki_names = exported(
20
21=== modified file 'lib/lp/registry/stories/webservice/xx-person.txt'
22--- lib/lp/registry/stories/webservice/xx-person.txt 2010-04-27 11:48:16 +0000
23+++ lib/lp/registry/stories/webservice/xx-person.txt 2010-05-12 14:15:42 +0000
24@@ -39,7 +39,6 @@
25 name: u'salgado'
26 open_membership_invitations_collection_link: u'http://.../~salgado/open_membership_invitations'
27 participants_collection_link: u'http://.../~salgado/participants'
28- pending_gpg_keys_collection_link: u'http://.../~salgado/pending_gpg_keys'
29 ppas_collection_link: u'http://.../~salgado/ppas'
30 preferred_email_address_link: u'http://.../~salgado/+email/guilherme.salgado@canonical.com'
31 private: False
32@@ -89,7 +88,6 @@
33 name: u'ubuntu-team'
34 open_membership_invitations_collection_link: u'http://.../~ubuntu-team/open_membership_invitations'
35 participants_collection_link: u'http://.../~ubuntu-team/participants'
36- pending_gpg_keys_collection_link: u'http://.../~ubuntu-team/pending_gpg_keys'
37 ppas_collection_link: u'http://.../~ubuntu-team/ppas'
38 preferred_email_address_link: u'http://.../~ubuntu-team/+email/support@ubuntu.com'
39 private: False